blender
/
blender
136
406
Fork 590
Code Issues 6.2k Pull Requests 764 Projects 19 Wiki Activity

Cleanup: use `e` prefix for enum, comment on misleading flag values 

Also replace "Feature" with "LineArt" in enum names.
This commit is contained in:
Campbell Barton 2021-03-23 13:22:54 +11:00
parent 80c86e274d
commit db5d9ddb1a
2 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
source/blender/makesdna/DNA_collection_types.h
View File

@ -46,7 +46,10 @@ typedef struct CollectionChild {
struct Collection *collection;
} CollectionChild;
enum CollectionFeatureLine_Usage {
/**
* \warning while the values seem to be flags, they aren't treated as flags.
*/
enum eCollectionLineArt_Usage {
COLLECTION_LRT_INCLUDE = 0,
COLLECTION_LRT_OCCLUSION_ONLY = (1 << 0),
COLLECTION_LRT_EXCLUDE = (1 << 1),

7
source/blender/makesdna/DNA_object_types.h
View File

@ -213,7 +213,10 @@ typedef struct ObjectLineArt {
float crease_threshold;
} ObjectLineArt;
enum ObjectFeatureLine_Usage {
/**
* \warning while the values seem to be flags, they aren't treated as flags.
*/
enum eObjectLineArt_Usage {
OBJECT_LRT_INHERIT = 0,
OBJECT_LRT_INCLUDE = (1 << 0),
OBJECT_LRT_OCCLUSION_ONLY = (1 << 1),
@ -222,7 +225,7 @@ enum ObjectFeatureLine_Usage {
OBJECT_LRT_NO_INTERSECTION = (1 << 4),
};
enum ObjectFeatureLine_Flags {
enum eObjectLineArt_Flags {
OBJECT_LRT_OWN_CREASE = (1 << 0),
};