blender
/
blender
136
405
Fork 586
Code Issues 6.2k Pull Requests 757 Projects 19 Wiki Activity

Geometry Nodes: Use std::move in dual mesh node 

Add a std::move in some places to prevent arrays from being copied.
These cases were potentially optimized by the compiler, but this makes
it more explicit.

Differential Revision: https://developer.blender.org/D14129
This commit is contained in:
Wannes Malfait 2022-02-28 15:16:01 -05:00 committed by Hans Goudey
parent 611157057b
commit eeb0279e89
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
source/blender/nodes/geometry/nodes/node_geo_dual_mesh.cc
View File

@ -646,13 +646,13 @@ static void calc_dual_mesh(GeometrySet &geometry_set,
Array<int> shared_edges(loop_indices.size());
vertex_ok = sort_vertex_polys(
mesh_in, i, false, edge_types, loop_indices, shared_edges, sorted_corners);
vertex_shared_edges[i] = shared_edges;
vertex_shared_edges[i] = std::move(shared_edges);
}
else {
Array<int> shared_edges(loop_indices.size() - 1);
vertex_ok = sort_vertex_polys(
mesh_in, i, true, edge_types, loop_indices, shared_edges, sorted_corners);
vertex_shared_edges[i] = shared_edges;
vertex_shared_edges[i] = std::move(shared_edges);
}
if (!vertex_ok) {
/* The sorting failed which means that the vertex is non-manifold and should be ignored
@ -660,7 +660,7 @@ static void calc_dual_mesh(GeometrySet &geometry_set,
vertex_types[i] = VertexType::NonManifold;
continue;
}
vertex_corners[i] = sorted_corners;
vertex_corners[i] = std::move(sorted_corners);
}
});