blender
/
blender
129
398
Fork 572
Code Issues 6.2k Pull Requests 746 Projects 19 Wiki Activity

Fix T80747: New vgroups on unsupported object types fails silently 

Raise an exceptions when adding vertex groups to object types
that don't support it.
This commit is contained in:
Campbell Barton 2020-09-14 18:25:54 +10:00
parent 14b0f20374
commit f28adaef52
Notes: blender-bot 2023-02-14 09:38:57 +01:00 
Referenced by issue #80747, bpy.data.objects['XXX'].vertex_groups.new(name = 'Test')
1 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
source/blender/makesrna/intern/rna_object.c
View File

@ -1828,8 +1828,19 @@ static void rna_Object_boundbox_get(PointerRNA *ptr, float *values)
}
}
static bDeformGroup *rna_Object_vgroup_new(Object *ob, Main *bmain, const char *name)
static bDeformGroup *rna_Object_vgroup_new(Object *ob,
Main *bmain,
ReportList *reports,
const char *name)
{
if (!OB_TYPE_SUPPORT_VGROUP(ob->type)) {
const char *ob_type_name = "Unknown";
RNA_enum_name_from_value(rna_enum_object_type_items, ob->type, &ob_type_name);
BKE_reportf(
reports, RPT_ERROR, "VertexGroups.new(): is not supported for '%s' objects", ob_type_name);
return NULL;
}
bDeformGroup *defgroup = BKE_object_defgroup_add_name(ob, name);
DEG_relations_tag_update(bmain);
@ -2489,7 +2500,7 @@ static void rna_def_object_vertex_groups(BlenderRNA *brna, PropertyRNA *cprop)
/* vertex groups */ /* add_vertex_group */
func = RNA_def_function(srna, "new", "rna_Object_vgroup_new");
RNA_def_function_flag(func, FUNC_USE_MAIN);
RNA_def_function_flag(func, FUNC_USE_MAIN | FUNC_USE_REPORTS);
RNA_def_function_ui_description(func, "Add vertex group to object");
RNA_def_string(func, "name", "Group", 0, "", "Vertex group name"); /* optional */
parm = RNA_def_pointer(func, "group", "VertexGroup", "", "New vertex group");