blender
/
blender
136
406
Fork 588
Code Issues 6.2k Pull Requests 755 Projects 19 Wiki Activity

Fix T103136: Cannot activate viewer node in group 

90ea1b7643 created an item for the viewer node path
but didn't add it to the list, which also caused memory leaks.
This commit is contained in:
Hans Goudey 2022-12-13 16:42:06 -06:00
parent a55163c880
commit f613614fce
Notes: blender-bot 2023-02-14 09:21:21 +01:00 
Referenced by issue #103136, Regression: Geometry Nodes: Viewer node permanently disabled inside node group
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
source/blender/editors/util/ed_viewer_path.cc
View File

@ -64,6 +64,7 @@ static void viewer_path_for_geometry_node(const SpaceNode &snode,
NodeViewerPathElem *node_elem = BKE_viewer_path_elem_new_node();
node_elem->node_id = node->identifier;
node_elem->node_name = BLI_strdup(node->name);
BLI_addtail(&r_dst.path, node_elem);
}
NodeViewerPathElem *viewer_node_elem = BKE_viewer_path_elem_new_node();
@ -111,7 +112,7 @@ void activate_geometry_node(Main &bmain, SpaceNode &snode, bNode &node)
}
}
/* Enable viewer in one viewport if it is disable in all of them. */
/* Enable viewer in one viewport if it is disabled in all of them. */
if (!found_view3d_with_enabled_viewer && any_view3d_without_viewer != nullptr) {
any_view3d_without_viewer->flag2 |= V3D_SHOW_VIEWER;
}