blender
/
blender
136
404
Fork 586
Code Issues 6.2k Pull Requests 761 Projects 19 Wiki Activity

PyAPI: unregister add-ons when exiting 

This lets add-on authors avoid false positive leaks when exiting.
In particular GPUShaders's although it applies to any PyObject that
stores memory allocated by guarded-alloc.

While this does add overhead on exit, on my system it's
under 1/100th of a second with all addons enabled.

See: T71362
This commit is contained in:
Campbell Barton 2020-10-16 16:34:29 +11:00
parent f40294b2d6
commit fa566157a5
Notes: blender-bot 2023-05-22 12:40:41 +02:00 
Referenced by issue #87271, Use after free when using an addon deriving from ShaderNodeCustomGroup
Referenced by issue #82675, "ImportError: sys.meta_path is None, Python is likely shutting down" on exit when built as a Python module
Referenced by issue #77348, Blender LTS: Maintenance Task 2.83
Referenced by issue #71362, Memory leak if both a shader and an AddonPreferences class are used
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
source/blender/windowmanager/intern/wm_init_exit.c
View File

@ -86,6 +86,7 @@
#ifdef WITH_PYTHON
# include "BPY_extern.h"
# include "BPY_extern_python.h"
# include "BPY_extern_run.h"
#endif
#include "GHOST_C-api.h"
@ -523,6 +524,14 @@ void WM_exit_ex(bContext *C, const bool do_python)
}
}
#ifdef WITH_PYTHON
/* Without this, we there isn't a good way to manage false-positive resource leaks
* where a #PyObject references memory allocated with guarded-alloc, T71362.
*
* This allows add-ons to free resources when unregistered (which is good practice anyway). */
BPY_run_string_eval(C, (const char *[]){"addon_utils", NULL}, "addon_utils.disable_all()");
#endif
BLI_timer_free();
WM_paneltype_clear();