blender
/
blender
134
399
Fork 583
Code Issues 6.3k Pull Requests 754 Projects 19 Wiki Activity

Fix Vector.project crash w/ >4 length vectors

This commit is contained in:
Campbell Barton 2018-07-27 17:40:01 +10:00
parent 3e2dfc6db8
commit fe8d8aa27e
Notes: blender-bot 2023-02-14 19:28:48 +01:00 
Referenced by issue blender/blender-addons#55374, Blender crashes when they use vector.project function
1 changed files with 7 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
source/blender/python/mathutils/mathutils_Vector.c
View File

@ -1127,23 +1127,17 @@ PyDoc_STRVAR(Vector_project_doc,
static PyObject *Vector_project(VectorObject *self, PyObject *value)
{
const int size = self->size;
float tvec[MAX_DIMENSIONS];
float vec[MAX_DIMENSIONS];
float *tvec;
double dot = 0.0f, dot2 = 0.0f;
int x;
if (mathutils_array_parse(tvec, size, size, value, "Vector.project(other), invalid 'other' arg") == -1)
return NULL;
if (self->size > 4) {
PyErr_SetString(PyExc_ValueError,
"Vector must be 2D, 3D or 4D");
return NULL;
}
if (BaseMath_ReadCallback(self) == -1)
return NULL;
if (mathutils_array_parse_alloc(&tvec, size, value, "Vector.project(other), invalid 'other' arg") == -1) {
return NULL;
}
/* get dot products */
for (x = 0; x < size; x++) {
dot += (double)(self->vec[x] * tvec[x]);
@ -1152,9 +1146,9 @@ static PyObject *Vector_project(VectorObject *self, PyObject *value)
/* projection */
dot /= dot2;
for (x = 0; x < size; x++) {
vec[x] = (float)dot * tvec[x];
tvec[x] *= (float)dot;
}
return Vector_CreatePyObject(vec, size, Py_TYPE(self));
return Vector_CreatePyObject_alloc(tvec, size, Py_TYPE(self));
}
PyDoc_STRVAR(Vector_lerp_doc,