Fine with me. If it's the same thing we should name it the same, otherwise it causes unnecessary confusion.

I think it's ok to rename, this kind of API breakage we'll have more of in 2.81. This particular property is not used in any add-on at least.

Think is fine, but interesting to hear from William.

I've posted a potential fix: D5288

@Sergey Sharybin (sergey) I'm guessing this an update event is missing?

I'm also not a huge fan of hiding the existance of fake users in the UI. While I understand that it confuses new people (trying to avoid the term "new users" here for clarity's sake), it also "forces" them to learn about how Blender handles data in general, and what the concept of user counting is. A fake user IS a second user of a datablock, as long as there is something else referencing the datablock. Not showing that will all the more confuse all the other people who have learned about the user count system.

That was not an intentional change, fixed in rB8401ee24ffe6: Fix issue in Blender 2.7x mask keymap after recent changes.

@Brecht Van Lommel (brecht) @Sergey Sharybin (sergey) Thanks so much for helping out with this. It also works great! :)
I am just not so sure about line 1191. When using the 27x keymap and rightclicking on a curve point it goes directly into transform mode. This feels a bit odd, since it should just select the point. If I want to drag a curve point with RMB I can simply rightclick and drag.

So as far as we can tell, "select" + "move" is mostly there for historical reasons and "slide" is really enough. So for the Blender LMB and industry compatible keymap we can have the context menu on RMB overriding it.

It appears that mask.slide_point also does selection, which means putting mask.select on RMB keeps selection on LMB working.

I am not sure from the top of my head what is involved here, would need to check myself.
Or maybe you can try implementing that behaviour and poke me with missing bits?

@Sergey Sharybin (sergey) is there anything I can do to help here?

I have removed the extra class and added a poll.
While doing the poll function I figured it would make sense to make the context menu aware of if there is a mask or not, so you can create an empty new mask or add a new mask with primitive shape from the context menu.

@Sergey Sharybin (sergey) hehe, no other pending changes at the moment, so you can apply. Thanks! :)

@Sebastian Jansson (sebastian): Do you have more pending updates, or i can apply the patch?

I noticed that the "Adjust Last Operation" checkbox was missing from the Clip Editor's View menu, so I added that.

I have fixed some inconsistent icons and elimated some whitespace.

In D5075#115569, @Sergey Sharybin (sergey) wrote:

Seems fine to add this back since it was not intended to be removed.

In D5070#115605, @Sergey Sharybin (sergey) wrote:

Well, somehow the closest functionality seems to be nodes, somehow. At least that is another big area where we allow selection, dragging, select-and-drag.
Shall we stick to the same rules for masking?

Well, somehow the closest functionality seems to be nodes, somehow. At least that is another big area where we allow selection, dragging, select-and-drag.
Shall we stick to the same rules for masking?

@Sergey Sharybin (sergey) What do you think of the issue @Brecht Van Lommel (brecht) mentioned?

From implementation seems fine.

I know, it's a bit weird, but when select is set to select_mouse (LMB by default), there is a conflict with the tweak functionality, so when you try to slide a single mask point, you slide the entire mask.
We had 2 different select modes in 2.79 as well: left-clicking would do a select + move when dragggin, right-clicking would select as well, and, if mouse dragged, would start a transform as well. However, only with RMB you could also extend the selection by holding shift.