new depsgraph removes the grass in victor scene #51977

New Issue

mathieu menuet · 2017-07-06T13:00:38+02:00

mathieu menuet commented

2017-07-06 13:00:38 +02:00

System Information
Win 7 x64, cpu and gpu render

Blender Version
Broken: f9963f2

Short description of error
all in title, enabling --enable-new-depsgraph make the grass to not render in the victor scene.

Exact steps for others to reproduce the error
start blender with --enable-new-depsgraph, open victor scene from benchmark pack, render: there is no grass. Do the same with old depsgraph, it renders coreectly.

**System Information** Win 7 x64, cpu and gpu render **Blender Version** Broken: f9963f2 **Short description of error** all in title, enabling --enable-new-depsgraph make the grass to not render in the victor scene. **Exact steps for others to reproduce the error** start blender with --enable-new-depsgraph, open victor scene from benchmark pack, render: there is no grass. Do the same with old depsgraph, it renders coreectly.

mathieu menuet commented

2017-07-06 13:00:38 +02:00

Changed status to: 'Open'

mathieu menuet commented

2017-07-06 13:00:38 +02:00

Added subscriber: @bliblubli

mathieu menuet commented

2017-07-07 11:39:59 +02:00

victor_cpu simple2.blend

[victor_cpu simple2.blend](https://archive.blender.org/developer/F654510/victor_cpu_simple2.blend)

Sergey Sharybin commented

2017-07-07 14:19:16 +02:00

Added subscriber: @Sergey

Sergey Sharybin self-assigned this 2017-07-07 14:19:16 +02:00

Sergey Sharybin commented

2017-07-07 14:19:16 +02:00

Developer note.

The issue is caused by new dependency graph not doing any extra updates tag when evaluating scene for newframe, while old dependency graph was tagging objects for update in various situations. One of such situations is tagging object for update on frame change when it has particle system (no matter enabled or disabled).

Now, in the file we've got situation, when object has Hair particle system which duplicates grass. This particle system is disabled in viewport.

What happens with old dependency graph:

Before rendering, ground object will have OB_DUPLI flag set to OFF, since there is nothing being duplicated.
Render engine will tag ground for update because it has particle system (happens in DAG_scene_update_flags),
Evaluation of scene will evaluate the object within render context, which will evaluate particle system which will set OB_DUPLI flag on ground object.
Cycles will see that object is a duplicator, and create grass.

What happens with new dependency graph:

Before rendering, ground object will have OB_DUPLI flag set to OFF, since there is nothing being duplicated.
Because nothing is dependent on time, no flush/tag happens
Cycles will NOT see that ground is a duplicator, because it was never yet evaluated for render context, meaning hair particle system did not set OB_DUPLI flag on the object.

Here is even smaller version of file untitled.blend

Developer note. The issue is caused by new dependency graph not doing any extra updates tag when evaluating scene for newframe, while old dependency graph was tagging objects for update in various situations. One of such situations is tagging object for update on frame change when it has particle system (no matter enabled or disabled). Now, in the file we've got situation, when object has Hair particle system which duplicates grass. This particle system is disabled in viewport. What happens with old dependency graph: - Before rendering, ground object will have `OB_DUPLI` flag set to OFF, since there is nothing being duplicated. - Render engine will tag ground for update because it has particle system (happens in `DAG_scene_update_flags`), - Evaluation of scene will evaluate the object within render context, which will evaluate particle system which will set `OB_DUPLI` flag on ground object. - Cycles will see that object is a duplicator, and create grass. What happens with new dependency graph: - Before rendering, ground object will have `OB_DUPLI` flag set to OFF, since there is nothing being duplicated. - Because nothing is dependent on time, no flush/tag happens - Cycles will NOT see that ground is a duplicator, because it was never yet evaluated for render context, meaning hair particle system did not set `OB_DUPLI` flag on the object. Here is even smaller version of file [untitled.blend](https://archive.blender.org/developer/F654637/untitled.blend)

blender-admin commented

2017-07-07 16:38:56 +02:00

This issue was referenced by 1e21778261

This issue was referenced by 1e217782617f3e57b989222995ce6b23e00e0eec

Sergey Sharybin commented

2017-07-07 16:39:57 +02:00

Changed status from 'Open' to: 'Resolved'

Sergey Sharybin closed this issue

2017-07-07 16:39:57 +02:00

mathieu menuet commented

2017-07-07 16:41:36 +02:00

After further investigation, not only the hidden particle system is triggering problems. In old depsgraph, it the subdivision modifier is also hidden, the particle system is evaluated, but at the wrong place. Only solution is to manually make it visible in viewport and change something that triggers a new evaluation many times, until it updates (like setting the particle system on and off. In some case, it has to be done 3 or 4 time to really update the particles positions)

This is the correct render after the hack explained above

This is the old depsgraph with modifiers evaluated in the wrong order

This with new depsgraph enabled:

bug part new depsgraph.blend

After further investigation, not only the hidden particle system is triggering problems. In old depsgraph, it the subdivision modifier is also hidden, the particle system is evaluated, but at the wrong place. Only solution is to manually make it visible in viewport and change something that triggers a new evaluation many times, until it updates (like setting the particle system on and off. In some case, it has to be done 3 or 4 time to really update the particles positions) This is the correct render after the hack explained above ![old depsgraph bug subdivision correct.png](https://archive.blender.org/developer/F654740/old_depsgraph_bug_subdivision_correct.png) This is the old depsgraph with modifiers evaluated in the wrong order ![old depsgraph bug subdivision.png](https://archive.blender.org/developer/F654741/old_depsgraph_bug_subdivision.png) This with new depsgraph enabled: ![old depsgraph bug subdivision new depsgraph.png](https://archive.blender.org/developer/F654742/old_depsgraph_bug_subdivision_new_depsgraph.png) [bug part new depsgraph.blend](https://archive.blender.org/developer/F654745/bug_part_new_depsgraph.blend)

mathieu menuet commented

2017-07-08 14:09:05 +02:00

Changed status from 'Resolved' to: 'Open'

mathieu menuet reopened this issue

2017-07-08 14:09:05 +02:00

mathieu menuet commented

2017-07-08 14:13:35 +02:00

Changed status from 'Open' to: 'Resolved'

mathieu menuet closed this issue

2017-07-08 14:13:35 +02:00

mathieu menuet commented

2017-07-08 14:13:35 +02:00