blender
/
blender
132
398
Fork 577
Code Issues 6.2k Pull Requests 748 Projects 19 Wiki Activity

Fix T44618: Rip Fill on a single vert would only generate one of the two expected faces. 

Was tagging (for filling) the wrong edge for one of the two involved loops...
This commit is contained in:
Bastien Montagne 2015-05-06 17:50:10 +02:00
parent 51f33a2e55
commit 4487358da7
Notes: blender-bot 2023-02-14 09:09:43 +01:00 
Referenced by issue #44618, Rip Fill does not work on a single vert.
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
source/blender/editors/mesh/editmesh_rip.c
View File

@ -784,11 +784,20 @@ static int edbm_rip_invoke__vert(bContext *C, wmOperator *op, const wmEvent *eve
else {
if (BM_edge_is_manifold(e_best)) {
BMLoop *l_iter, *l_first;
l_iter = l_first = e_best->l;
do {
larr[larr_len] = BM_edge_vert_share_loop(l_iter, v);
BM_elem_flag_enable(larr[larr_len]->e, BM_ELEM_TAG);
if (do_fill) {
/* Only needed when filling...
* Also, we never want to tag best edge, that one won't change during split. See T44618. */
if (larr[larr_len]->e == e_best) {
BM_elem_flag_enable(larr[larr_len]->prev->e, BM_ELEM_TAG);
}
else {
BM_elem_flag_enable(larr[larr_len]->e, BM_ELEM_TAG);
}
}
larr_len++;
} while ((l_iter = l_iter->radial_next) != l_first);
}