Remove Unnecessary Confirmation Popups #37422

New Issue

Jonathan Williamson · 2013-11-13T23:04:24+01:00

2013-11-13 23:04:24 +01:00

Issue Description

Ever since Blender got Undo we've had a series of unnecessary Confirmation popups that block user flow and interaction. For example, when deleting an object Blender always gives a Ok? Delete. These are no longer necessary.

Design Decision

Let's remove those that are no longer needed, but ensure we provide good user feedback with an info message when they are.

Ongoing work

See D35: #37421/T37422 Remove Unnecessary Confirmation Popups

**Issue Description** Ever since Blender got Undo we've had a series of unnecessary Confirmation popups that block user flow and interaction. For example, when deleting an object Blender always gives a Ok? Delete. These are no longer necessary. **Design Decision** Let's remove those that are no longer needed, but ensure we provide good user feedback with an info message when they are. **Ongoing work** See [D35: #37421/T37422 Remove Unnecessary Confirmation Popups](https://archive.blender.org/developer/D35)

Jonathan Williamson commented

2013-11-13 23:04:24 +01:00

Changed status to: 'Open'

Jonathan Williamson commented

2013-11-13 23:04:24 +01:00

Added subscribers: @JonathanWilliamson, @brecht

blender-admin commented

2013-11-13 23:04:24 +01:00

#37421 was marked as duplicate of this issue

Brecht Van Lommel commented

2013-11-14 13:08:27 +01:00

A message like "N objects deleted" in the info header could be used, so that if you press it accidentally on some object outside of the view there's still feedback.

Jonathan Williamson commented

2013-11-14 17:19:22 +01:00

@brecht, that would be ideal. Anytime we're making changes like this, particularly when it involves removing user interaction, I think we should be sure to report changes to the user. Feedback is crucial, that feedback just shouldn't be blocking.

William Reynish commented

2013-11-15 21:53:03 +01:00

Added subscriber: @billrey

William Reynish commented

2013-11-15 21:53:03 +01:00

I don't understand the original description: "The Confirm to Delete popup is no longer necessary now that we have delete." ?

Now that we have delete? What does this mean?

As for warning popups, I think the previous rule was to only add these popup warnings for destructive actions.

I'm fine with them being removed, if we add clear feedback in the header. Otherwise it's too easy to accidentally brush your arm against the X key and see your beautiful creation disappear into the void.

I don't understand the original description: "The Confirm to Delete popup is no longer necessary now that we have delete." ? Now that we have delete? What does this mean? As for warning popups, I think the previous rule was to only add these popup warnings for destructive actions. I'm fine with them being removed, *if* we add clear feedback in the header. Otherwise it's too easy to accidentally brush your arm against the X key and see your beautiful creation disappear into the void.

Jonathan Williamson commented

2013-11-15 21:55:38 +01:00

@billrey, whoops my bad. I've updated the description.

Diego Gangl commented

2013-11-19 00:18:25 +01:00

Added subscriber: @Januz

Diego Gangl commented

2013-11-19 00:18:25 +01:00

Isn't this a duplicate of http://developer.blender.org/T37421 (or a part of it)?

Brecht Van Lommel commented

2013-11-19 00:25:54 +01:00

It is a subtask, although the Dependent Tasks and Depends On terminology doesn't make that really clear.

Diego Gangl commented

2013-11-19 00:34:59 +01:00

oops, sorry I didn't notice that.

Emanuel Claesson commented

2013-11-24 04:40:37 +01:00

Added subscriber: @EClaesson

Brecht Van Lommel changed title from ~~Remove Confirm to Delete~~ to Remove Unnecessary Confirmation Popups

2013-11-24 18:23:27 +01:00

Brecht Van Lommel commented

2013-11-24 18:23:57 +01:00

◀ Merged tasks: #37421.

Harley Acheson commented

2013-11-24 19:18:30 +01:00

Added subscriber: @Harley

Harley Acheson commented

2013-11-24 19:18:30 +01:00

As far as I can tell there are exactly 6 places where we get a confirmation popup:

OBJECT_OT_delete - "Delete selected objects"
VIEW3D_OT_copybuffer - "Copy selected object to to Buffer"
VIEW3D_OT_pastebuffer - "Paste new object from Buffer"
SCREEN_OT_screencast - "Make Screencast"
FILE_OT_directory_new - "Create a new directory"
WM_OT_save_homefile - "Save Startup File"

The confirmation on object deletion seems pretty silly if you use the "delete" key, but comes in handy if you normally use "X" to delete since it is easy to hit accidentally when doing G->X, R->X, etc. I wonder if it is worth considering leaving the confirmation for "X" and removing it for the "Delete" key? Personally, I'd remove these confirmation always, replaced with "X Objects deleted" printed in the header area.

Copy and paste to/from buffer confirmation can be removed, replaced with info text. "Object copied to clipboard", "Object pasted from clipboard"

Starting a screencast should never have a confirmation.

Creating a new directory. If you select this option from a menu then there should be no confirmation. But if you've typed a directory name in a path then the confirmation should happen, as well as if you press the "I" shortcut to make a directory.

The last one, "Save Startup File", should probably keeps its confirmation.

As far as I can tell there are exactly 6 places where we get a confirmation popup: OBJECT_OT_delete - "Delete selected objects" VIEW3D_OT_copybuffer - "Copy selected object to to Buffer" VIEW3D_OT_pastebuffer - "Paste new object from Buffer" SCREEN_OT_screencast - "Make Screencast" FILE_OT_directory_new - "Create a new directory" WM_OT_save_homefile - "Save Startup File" The confirmation on object deletion seems pretty silly if you use the "delete" key, but comes in handy if you normally use "X" to delete since it is easy to hit accidentally when doing G->X, R->X, etc. I wonder if it is worth considering leaving the confirmation for "X" and removing it for the "Delete" key? Personally, I'd remove these confirmation always, replaced with "X Objects deleted" printed in the header area. Copy and paste to/from buffer confirmation can be removed, replaced with info text. "Object copied to clipboard", "Object pasted from clipboard" Starting a screencast should never have a confirmation. Creating a new directory. If you select this option from a menu then there should be no confirmation. But if you've typed a directory name in a path then the confirmation should happen, as well as if you press the "I" shortcut to make a directory. The last one, "Save Startup File", should probably keeps its confirmation.

blender-admin commented

2013-11-25 12:21:45 +01:00

This issue was referenced by blender/blender-addons-contrib@3ca4387bc8

This issue was referenced by blender/blender-addons-contrib@3ca4387bc80b17d945d3ced2f55fd2ae6d962b1b

Warren Bahler commented

2013-12-04 20:28:07 +01:00

Added subscriber: @WarrenBahler

Warren Bahler commented

2013-12-04 20:28:07 +01:00

Also there is

"Save over? ###.blend" on save

I think we can safely assume,like almost any other software assumes, that the active file is the one to save over. If the user wants to make a new version of a file, its most likely he's already copied it with a unique name.

but this should maybe stay.

Also there is "Save over? ###.blend" on save I think we can safely assume,like almost any other software assumes, that the active file is the one to save over. If the user wants to make a new version of a file, its most likely he's already copied it with a unique name. but this should maybe stay.

Jonathan Williamson commented

2013-12-04 21:05:15 +01:00

I have no problem with removing the Save over? popup. What do you think @brecht?

I have no problem with removing the **Save over?** popup. What do you think @brecht?

Brecht Van Lommel commented

2013-12-04 21:19:19 +01:00

Well, it's an action we can't undo so if we are going with that rule we should keep it. But I guess it's quite standard not to ask in this case so it seems reasonable.

If that popup is removed we should make sure it's only for the case where you are saving to the file that you opened or already saved to, when you save to a different file there should still be a popup.

Well, it's an action we can't undo so if we are going with that rule we should keep it. But I guess it's quite standard not to ask in this case so it seems reasonable. If that popup is removed we should make sure it's only for the case where you are saving to the file that you opened or already saved to, when you save to a different file there should still be a popup.

Jonathan Williamson commented

2013-12-04 21:23:52 +01:00

@brecht, agreed. If it's a new file or overwriting a different file then it should pop up.

It's quite standard to simply the save the current file with CTRL+S, without any confirmation. And actually, this is undoable since we save .blend1. As with other cases, I suggest we report to the Info panel that the file has been saved.

@brecht, agreed. If it's a new file or overwriting a different file then it should pop up. It's quite standard to simply the save the current file with CTRL+S, without any confirmation. And actually, this is undoable since we save .blend1. As with other cases, I suggest we report to the Info panel that the file has been saved.

Jonathan Williamson commented

2013-12-15 18:07:36 +01:00

Changed status from 'Open' to: 'Resolved'

Jonathan Williamson closed this issue

2013-12-15 18:07:36 +01:00

michael knubben commented

2015-11-26 20:05:01 +01:00

Added subscriber: @michaelknubben

michael knubben commented

2015-11-26 20:05:01 +01:00

This was set to 'resolved', but the Save and Delete commands were actually never 'liberated' from their confirmation, while as far as I can tell there was concencus to do so.

Aaron Carlisle commented

2015-11-26 22:51:46 +01:00

Added subscriber: @Blendify

Aaron Carlisle commented

2015-11-26 22:51:46 +01:00

I think changes have bee made already see:

3ca4387bc8
blender/blender-staging@3ca4387bc8

I think changes have bee made already see: 3ca4387bc8 blender/blender-staging@3ca4387bc8

michael knubben commented

2015-11-28 11:11:08 +01:00

Where in these links do you see anything to indicate what I said was incorrect?

As I mentioned, the Save and Delete commands still have confirmation popups, and at least Jonathan and Brecht seemed to agree they should not. If it matters: So do I.

Where in these links do you see anything to indicate what I said was incorrect? As I mentioned, the Save and Delete commands still have confirmation popups, and at least Jonathan and Brecht seemed to agree they should not. If it matters: So do I.

michael knubben commented

2016-02-26 10:42:08 +01:00

@JonathanWilliamson: As the author of this, are you aware of a reason for this? There was consensus on the Save and Delete commands, was there any pushback from anyone outside of this design task, or what happened?

Jonathan Williamson commented

2016-03-08 16:22:14 +01:00

@michaelknubben I don't off the top of my head, it's been a while. We can bring this back up during the UI meeting if needed. The Save/Delete popups are the most drastic changes, so if anything are worth discussing again.

Robin Hahn commented

2016-07-03 23:22:44 +02:00

Added subscriber: @RobinHahn

Robin Hahn commented

2016-07-03 23:22:44 +02:00

I use Blender primarily as video-editor these days. The - [x]elete key - vs - [x] : delete - does not appear to delete video segments or indeed anything from the VSE timeline. - [x] does, but always with the confirmation popup.
Just wondering how hard it would be to add a toggle in the preferences to disable the confirmation popup. I realise this would have to be an application-wide solution, but even when modelling it's never proven itself invaluable, particularly since we do have undo.

I use Blender primarily as video-editor these days. The - [x]elete key - vs - [x] : delete - does not appear to delete video segments or indeed anything from the VSE timeline. - [x] does, but always with the confirmation popup. Just wondering how hard it would be to add a toggle in the preferences to disable the confirmation popup. I realise this would have to be an application-wide solution, but even when modelling it's never proven itself invaluable, particularly since we do have undo.

Carlo Andreacchio commented

2016-07-04 04:05:01 +02:00

Added subscriber: @candreacchio

Carlo Andreacchio commented

2016-07-04 04:05:01 +02:00

Few thoughts on deleting from another point of view (it came up a few years back, tried to find the thread but cant)

In terms of deleting & 3D view, i think it is important to keep consistency between edit mode deleting and object mode deleting. as in, if there is a popup for editmode deleting, object mode deleting should follow suit.

X as well is very close to z which is switch to wireframe, when you are working in a fast workflow, it is quite possible to hit this accidentally. If you delete an object and you are working in a very heavy scene, undo can take up to 10-15 seconds to process, which then would break the flow of the artist.

I am for keeping the 'delete' button with no popup, but having the x with a popup.

EDIT: Found the thread -- https://developer.blender.org/T37801

Few thoughts on deleting from another point of view (it came up a few years back, tried to find the thread but cant) In terms of deleting & 3D view, i think it is important to keep consistency between edit mode deleting and object mode deleting. as in, if there is a popup for editmode deleting, object mode deleting should follow suit. X as well is very close to z which is switch to wireframe, when you are working in a fast workflow, it is quite possible to hit this accidentally. If you delete an object and you are working in a very heavy scene, undo can take up to 10-15 seconds to process, which then would break the flow of the artist. I am for keeping the 'delete' button with no popup, but having the x with a popup. EDIT: Found the thread -- https://developer.blender.org/T37801

michael knubben commented

2016-08-01 10:07:59 +02:00

So it seems the save confirmation is the proverbial baby that was thrown out with the bathwater? Brecht just added that back in together with the delete, even though the save confirmation was decided on and nobody had an issue with it.
I also take issue with solving a keymap issue (which is something the user can change!) with an intrusive solution that also impacts those that remap their hotkeys.
So, since there was concensus, can we get rid of the save confirmation again, at least?

So it seems the save confirmation is the proverbial baby that was thrown out with the bathwater? Brecht just added that back in together with the delete, even though the save confirmation was decided on and nobody had an issue with it. I also take issue with solving a keymap issue (which is something the user can change!) with an intrusive solution that also impacts those that remap their hotkeys. So, since there was concensus, can we get rid of the save confirmation again, at least?

michael knubben commented

2016-12-22 10:55:22 +01:00

Since the UI team has met up now, has this been discussed?

michael knubben commented

2018-01-30 09:16:58 +01:00

Since there has been some time to think this over: any update on this?

Carlo Andreacchio commented

2018-01-31 06:56:04 +01:00

Not an official dev but part of the previous discussion.

I think the save dialogue is still nice to have confirmation, some large files (300+ mb) saving to network drives can lock up blender for 10 or so seconds. having it pop up on ctrl s is important as it is right next to ctrl a (apply) and having that dialogue box that you can easily close out of is important.

The alternative is to move the save function to a different hotkey which isnt in prime realestate.

Not an official dev but part of the previous discussion. I think the save dialogue is still nice to have confirmation, some large files (300+ mb) saving to network drives can lock up blender for 10 or so seconds. having it pop up on ctrl s is important as it is right next to ctrl a (apply) and having that dialogue box that you can easily close out of is important. The alternative is to move the save function to a different hotkey which isnt in prime realestate.

michael knubben commented

2018-02-02 11:18:12 +01:00

Ctrl-s being next to ctrl-a is the case in all software, ever. It (and X) being 'easily accesible' is also more of a point in favour of changing the hotkey than introducing a popup, in my opinion.
You have to wonder why Blender would be the only software in the world that need training wheels on ctrl-s, but what really gets me is that there's no way for the user to turn this off!

Ctrl-s being next to ctrl-a is the case in all software, ever. It (and X) being 'easily accesible' is also more of a point in favour of changing the hotkey than introducing a popup, in my opinion. You have to wonder why Blender would be the only software in the world that need training wheels on ctrl-s, but what really gets me is that there's no way for the user to turn this off!

michael knubben commented

2018-02-02 15:39:43 +01:00

In #37422#362702, @JonathanWilliamson wrote:
@michaelknubben I don't off the top of my head, it's been a while. We can bring this back up during the UI meeting if needed. The Save/Delete popups are the most drastic changes, so if anything are worth discussing again.

You mentioned bringing this up, did anything ever come of it, and if not: why is this off the table?

> In #37422#362702, @JonathanWilliamson wrote: > @michaelknubben I don't off the top of my head, it's been a while. We can bring this back up during the UI meeting if needed. The Save/Delete popups are the most drastic changes, so if anything are worth discussing again. You mentioned bringing this up, did anything ever come of it, and if not: why is this off the table?

Henrik Berglund commented

2018-02-02 22:02:39 +01:00

Added subscriber: @cyaoeu

Henrik Berglund commented

2018-02-02 22:02:39 +01:00

It is a bit weird because there's a Check Existing flag in the operator with the description "Check and warn on overwriting files" but it doesn't actually do anything which seems like a bug. It's set to True by default but set to False it should disable the warning popup that is hard coded right now it seems like. Then when this is fixed similar props could be added to the Delete operator and any other operators that do this.

peter commented

2019-06-21 04:25:35 +02:00

Added subscriber: @polynut

peter commented

2019-06-21 04:25:35 +02:00

Please give us an option to disable those confirmation pop up it simply slow us down and tonight i am spending an hour just to install an addon that disable it but the addon disable something else in the keymap. This is counter productive.

William Reynish commented

2019-06-21 08:08:11 +02:00

Added subscriber: @WilliamReynish

William Reynish commented

2019-06-21 08:08:11 +02:00

We already got rid of almost all occurrences - which examples are you referring to?

peter commented

2019-06-24 08:37:31 +02:00

Hi William,

I was talking about the one when you want to delete a face in edit mode!

Hi William, I was talking about the one when you want to delete a face in edit mode!

William Reynish commented

2019-06-24 09:24:55 +02:00

There should be no extra confirmation popup when deleting faces - how exactly do you make that appear?

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Remove Unnecessary Confirmation Popups #37422