fix shift buttons with certain input devices (huion tablets) #59882

New Issue

Daniel Grauer · 2018-12-26T23:52:37+01:00

Daniel Grauer commented

2018-12-26 23:52:37 +01:00

I made a fix for the shift button that has been reported a couple of times to not be working with certain input devices, and since i just got some huion tablets and experienced the issue myself it was something i could directly test.
However since my knowledge with coding is limited i might have not understood some of the decision for the earlier implementation.

bugreports:
https://developer.blender.org/T49239
https://developer.blender.org/T59854

patch.diff
https://developer.blender.org/differential/diff/13033/

I have tested this only on PC so far, so if someone could test this on a mac would be great.

OS: windows 10 64bit
Devices Tested:

Wacom Intuos Pro (5th generation)
Huion H950P
Huion Camvas 13 pro
PC Keyboard (US layout)

I made a fix for the shift button that has been reported a couple of times to not be working with certain input devices, and since i just got some huion tablets and experienced the issue myself it was something i could directly test. However since my knowledge with coding is limited i might have not understood some of the decision for the earlier implementation. bugreports: https://developer.blender.org/T49239 https://developer.blender.org/T59854 [patch.diff](https://archive.blender.org/developer/F6080524/patch.diff) https://developer.blender.org/differential/diff/13033/ I have tested this only on PC so far, so if someone could test this on a mac would be great. OS: windows 10 64bit Devices Tested: - Wacom Intuos Pro (5th generation) - Huion H950P - Huion Camvas 13 pro - PC Keyboard (US layout)

Daniel Grauer commented

2018-12-26 23:52:37 +01:00

Added subscriber: @DanielGrauer

Bastien Montagne was assigned by Daniel Grauer

2018-12-27 08:39:15 +01:00

Bastien Montagne removed their assignment 2018-12-27 10:08:52 +01:00

Bastien Montagne commented

2018-12-27 10:08:52 +01:00

Added subscribers: @dan-34, @mont29

Bastien Montagne commented

2018-12-27 10:08:52 +01:00

@dan-34 grauer I’d like to know why you assign that to me? That’s not especially my area, certainly not for win/mac OS's…

And please submit a diff (https://developer.blender.org/differential/diff/create/), which you can then reference in both #49239 and #59854, much easier to handle review that way. ;)

@dan-34 grauer I’d like to know why you assign that to me? That’s not especially my area, certainly not for win/mac OS's… And please submit a diff (https://developer.blender.org/differential/diff/create/), which you can then reference in both #49239 and #59854, much easier to handle review that way. ;)

Daniel Grauer commented

2018-12-27 10:35:41 +01:00

@mont29 ive seen you active on some older ticket related to this so i thought you would be the correct person to assign, guess i was wrong. sorry for that.
thanks for mentioning the diff creation, its really a lot easier than the patch.

@mont29 ive seen you active on some older ticket related to this so i thought you would be the correct person to assign, guess i was wrong. sorry for that. thanks for mentioning the diff creation, its really a lot easier than the patch.

Bastien Montagne commented

2018-12-27 10:39:37 +01:00

No proplem, please continue the process though (create a new revision using the 'continue' button on the diff page) ;)

Then we can close that task.

No proplem, please continue the process though (create a new revision using the 'continue' button on the diff page) ;) Then we can close that task.

Daniel Grauer commented

2018-12-27 10:48:25 +01:00

@mont29 its done i think:D