Multires: normals not updating when using smooth shading #62282

New Issue

Enrique Barranco · 2019-03-06T21:30:41+01:00

Enrique Barranco commented

2019-03-06 21:30:41 +01:00

System Information
Operating system: Linux
Graphics card: Nvidia GeForce GTX 1050 Ti

Blender Version
Broken:
March 06, 14:18:14 - 3fc7d51ed3d3Beta

Worked:

Short description of error

Smooth Shading in sculpting mode does not update correctly when you deactivate Overlays.

Exact steps for others to reproduce the error

Open Blender.
Right click on cube shade smooth.
Change to sculpt Mode.
Use Mutires modifier.
Deactivate Overlays.
Try to sculpt

You can watch the behavior here.

**System Information** Operating system: Linux Graphics card: Nvidia GeForce GTX 1050 Ti **Blender Version** Broken: March 06, 14:18:14 - 3fc7d51ed3d3Beta Worked: **Short description of error** Smooth Shading in sculpting mode does not update correctly when you deactivate Overlays. **Exact steps for others to reproduce the error** 1. Open Blender. 2. Right click on cube shade smooth. 3. Change to sculpt Mode. 4. Use Mutires modifier. 5. Deactivate Overlays. 6. Try to sculpt [You can watch the behavior here. ](https://youtu.be/LAcCimLGIUs)

Enrique Barranco commented

2019-03-06 21:30:41 +01:00

Added subscriber: @ebarranco

blender-admin commented

2019-03-06 21:30:41 +01:00

#64340 was marked as duplicate of this issue

blender-admin commented

2019-03-06 21:30:41 +01:00

#64778 was marked as duplicate of this issue

blender-admin commented

2019-03-06 21:30:41 +01:00

#64586 was marked as duplicate of this issue

blender-admin commented

2019-03-06 21:30:41 +01:00

#64353 was marked as duplicate of this issue

blender-admin commented

2019-03-06 21:30:41 +01:00

#64286 was marked as duplicate of this issue

blender-admin commented

2019-03-06 21:30:41 +01:00

#64227 was marked as duplicate of this issue

blender-admin commented

2019-03-06 21:30:41 +01:00

#63461 was marked as duplicate of this issue

blender-admin commented

2019-03-06 21:30:41 +01:00

#62291 was marked as duplicate of this issue

blender-admin commented

2019-03-06 21:30:41 +01:00

#62292 was marked as duplicate of this issue

blender-admin commented

2019-03-06 21:30:41 +01:00

#62290 was marked as duplicate of this issue

Sergey Sharybin was assigned by Sebastian Parborg

2019-03-07 11:15:45 +01:00

Sergey Sharybin removed their assignment 2019-03-07 11:25:42 +01:00

Clément Foucault was assigned by Sergey Sharybin

2019-03-07 11:25:42 +01:00

Sergey Sharybin commented

2019-03-07 11:25:42 +01:00

Added subscriber: @Sergey

Sergey Sharybin commented

2019-03-07 11:25:42 +01:00

Overlays is not something i can control from sculpt/multires.

Sebastian Parborg commented

2019-03-07 11:29:33 +01:00

Added subscriber: @gentleclockdivider

Clément Foucault commented

2019-03-25 16:29:37 +01:00

It looks like normals are not being recalculated for some reason.

Clément Foucault was unassigned by Brecht Van Lommel

2019-03-26 13:35:44 +01:00

Jeroen Bakker was assigned by Brecht Van Lommel

2019-03-26 13:35:44 +01:00

Brecht Van Lommel commented

2019-03-26 13:35:44 +01:00

Added subscriber: @fclem

Sebastian Parborg commented

2019-04-11 12:35:10 +02:00

Added subscriber: @moisessalvador

Sebastian Parborg commented

2019-05-08 14:08:11 +02:00

Added subscribers: @BacMan12, @ZedDB

Sebastian Parborg commented

2019-05-08 14:09:03 +02:00

Now it doesn't work with smooth shading (overlays doesn't seem to matter anymore).

Sebastian Parborg commented

2019-05-08 14:46:22 +02:00

Added subscriber: @hirvijk

muhamad wicaksono commented

2019-05-08 15:29:07 +02:00

Hello, for some reason with a more complex scene the bug behavior changes, now it computes after strokes end, with an addition now I can't undo strokes, it will only undo to the first sculpt stroke, not to the previous stroke.

dd9cebeb08f1ad4120b59855e93258e3.mp4

here is the file with more complex scene.
multires_bug.blend

Hello, for some reason with a more complex scene the bug behavior changes, now it computes after strokes end, with an addition now I can't undo strokes, it will only undo to the first sculpt stroke, not to the previous stroke. [dd9cebeb08f1ad4120b59855e93258e3.mp4](https://archive.blender.org/developer/F7015456/dd9cebeb08f1ad4120b59855e93258e3.mp4) here is the file with more complex scene. [multires_bug.blend](https://archive.blender.org/developer/F7015434/multires_bug.blend)

Sebastian Parborg commented

2019-05-10 12:21:58 +02:00

Added subscriber: @MassimilianoPuliero

Jeroen Bakker changed title from ~~Smooth Shading in sculpting mode does not update correctly when deactivate Overlays.~~ to Smooth Shading Not Updating When Using MultiRes Sculpting

2019-05-15 10:20:42 +02:00

Jorge Bouza commented

2019-05-15 20:31:22 +02:00

Added subscriber: @JorgeBouza

Alex commented

2019-05-23 04:22:11 +02:00

Added subscriber: @AlexanderKrause

Alex commented

2019-05-23 04:22:11 +02:00

I just realized that I reported something very similar here: #64586
Although, it happens independent from the overlays to me.

Another report about this can also be found here: #64778

The last version of 2.8 where the normal updates for multires still worked at all was: version: 2.80 (sub 60), branch: blender2.7, commit date: 2019-05-03 21:09, hash: ee0d8426ab

This is too bad because it makes sculpting somewhat unusable in 2.8.

The normal update also occurs when simply leaving sculpt-mode by going back to object-mode or when changing anything in the object geometry-data.

I just realized that I reported something very similar here: [#64586 ](https://developer.blender.org/T64586) Although, it happens independent from the overlays to me. Another report about this can also be found here: [#64778 ](https://developer.blender.org/T64778) The last version of 2.8 where the normal updates for multires still worked at all was: version: 2.80 (sub 60), branch: blender2.7, commit date: 2019-05-03 21:09, hash: ee0d8426ab This is too bad because it makes sculpting somewhat unusable in 2.8. The normal update also occurs when simply leaving sculpt-mode by going back to object-mode or when changing anything in the object geometry-data.

Addison commented

2019-05-25 01:02:59 +02:00

Added subscriber: @seaside98-4

Nikita Glushkov commented

2019-05-27 16:54:14 +02:00

Added subscriber: @ncuxonaTZopa

Brecht Van Lommel commented

2019-05-29 14:35:37 +02:00

Added subscriber: @brecht

Brecht Van Lommel commented

2019-05-29 14:35:37 +02:00

Marking as high priority given the number of reports.

Brecht Van Lommel changed title from ~~Smooth Shading Not Updating When Using MultiRes Sculpting~~ to Multires: normals not updating when using smooth shading

2019-05-29 14:35:53 +02:00

Brecht Van Lommel commented

2019-05-29 14:36:04 +02:00

Added subscribers: @tibor81, @RavenMask, @TomyB

Brecht Van Lommel commented

2019-05-29 14:36:24 +02:00

Added subscriber: @ajlanaltug

Jeroen Bakker commented

2019-05-29 15:55:42 +02:00

One of the next commits is the source of the issue.

b2f1a65874 (Skipped due to compile error)
fb3b2ab709 (Skipped due to compile error)
f302224e16 (First compilable bad commit)

Will fix the issues per commit to see who is the actual source of the issue.
fb3b2ab709 Seems to be the issue. It removed the function DRW_cache_mesh_sculpt_coords_ensure and the call to it. Will need to check with @fclem what would be the correct solution to move forward.

One of the next commits is the source of the issue. b2f1a65874 (Skipped due to compile error) fb3b2ab709 (Skipped due to compile error) f302224e16 (First compilable bad commit) Will fix the issues per commit to see who is the actual source of the issue. fb3b2ab709 Seems to be the issue. It removed the function `DRW_cache_mesh_sculpt_coords_ensure` and the call to it. Will need to check with @fclem what would be the correct solution to move forward.

Jeroen Bakker commented

2019-05-29 16:05:51 +02:00

@fclem solution to move forward is:

if you want to fix this do it in drw_sculpt_generate_calls to avoid duplication. I think its a matter of porting what sculpt_update_pbvh_normals was doing

@fclem solution to move forward is: > if you want to fix this do it in drw_sculpt_generate_calls to avoid duplication. I think its a matter of porting what sculpt_update_pbvh_normals was doing

Alex commented

2019-05-29 16:17:36 +02:00

Yay!! :D