GPencil: Canvas Plane Is Hidden By Objects / is no longer X-Ray #76366

New Issue

shanenewville@gmail.com · 2020-05-03T09:54:48+02:00

2020-05-03 09:54:48 +02:00

System Information
Operating system: Windows 7 64bit Pro
Graphics card: NVIDIA GeForce 970 GTX

Blender Version
Broken: 2.83, 1623fdb3bc, Beta, 2020-05-02
Worked: 2.82a

Short description of error
With Grease Pencil we would use the canvas plane to assist with drawing, but it is quite difficult to use when it is both hidden by ojects due to no longer being xray and also is locked the center of the scene no longer follow 3D Cursor. There appears to be no option to make it xray like it should be. Or if there is, its not clear where to find it. But it should be on by default. The Plane used to be visible by default no matter what is in front of it.

Separate ticket created for the second mentioned issue: https://developer.blender.org/T76364

Exact steps for others to reproduce the error

Create a new basic scene with default cube, or just add a cube (Make sure it is in the center of the scene)
Add a Grease Pencil > Blank object.
Set Viewport shading to Rendered
Click Overlays dropdown and enable both Canvas and 3D Cursor
Set the Drawing Plane setting to View, Top, Side, Front or Curor. Notice that the Drawing plane is completely hidden by the default Cube (or any object)

**System Information** Operating system: Windows 7 64bit Pro Graphics card: NVIDIA GeForce 970 GTX **Blender Version** Broken: 2.83, 1623fdb3bc55, Beta, 2020-05-02 Worked: 2.82a **Short description of error** With Grease Pencil we would use the canvas plane to assist with drawing, but it is quite difficult to use when it is both hidden by ojects due to no longer being xray and also is locked the center of the scene no longer follow 3D Cursor. There appears to be no option to make it xray like it should be. Or if there is, its not clear where to find it. But it should be on by default. The Plane used to be visible by default no matter what is in front of it. - Separate ticket created for the second mentioned issue: https://developer.blender.org/T76364 ![2_83.jpg](https://archive.blender.org/developer/F8508868/2_83.jpg) **Exact steps for others to reproduce the error** 1. Create a new basic scene with default cube, or just add a cube (Make sure it is in the center of the scene) 2. Add a Grease Pencil > Blank object. 3. Set Viewport shading to Rendered 4. Click Overlays dropdown and enable both Canvas and 3D Cursor 5. Set the Drawing Plane setting to View, Top, Side, Front or Curor. Notice that the Drawing plane is completely hidden by the default Cube (or any object)

shanenewville@gmail.com commented

2020-05-03 09:54:48 +02:00

Added subscriber: @Ghost_Train

Antonio Vazquez commented

2020-05-03 16:14:12 +02:00

Added subscribers: @fclem, @antoniov

Antonio Vazquez commented

2020-05-03 16:14:12 +02:00

I don't think this is a bug... the gird is "inside" the cube, so if you draw anything, the final stroke will go "inside".

@fclem Any comment about that?

I don't think this is a bug... the gird is "inside" the cube, so if you draw anything, the final stroke will go "inside". @fclem Any comment about that?

Antonio Vazquez changed title from ~~Canvas Plane Is Hidden By Objects / is no longer X-Ray~~ to GPencil: Canvas Plane Is Hidden By Objects / is no longer X-Ray

2020-05-03 16:14:42 +02:00

shanenewville@gmail.com commented

2020-05-03 23:24:11 +02:00

@antoniov An example of how I expected it to work can be seen in this recent tutorial by Dedouze. As seen in the video, the canvas drawing plane has xray. This is how it works in 2.82. In 2.83 it is not working like this and is hidden by objects making it difficult to see how the plane is oriented.
https://youtu.be/c57qq2nE3B0?t=970

It defeats the purpose of the canvas plane as a tool that assists with drawing. If we don't want to see it we can just uncheck it from the outlines dropdown and drawing still works the same. The point of this ticket is, when we enable canvas, we cannot see it anymore in 2.83 if it is covered by objects in the scene.

@antoniov An example of how I expected it to work can be seen in this recent tutorial by Dedouze. As seen in the video, the canvas drawing plane has xray. This is how it works in 2.82. In 2.83 it is not working like this and is hidden by objects making it difficult to see how the plane is oriented. https://youtu.be/c57qq2nE3B0?t=970 It defeats the purpose of the canvas plane as a tool that assists with drawing. If we don't want to see it we can just uncheck it from the outlines dropdown and drawing still works the same. The point of this ticket is, when we enable canvas, we cannot see it anymore in 2.83 if it is covered by objects in the scene.

shanenewville@gmail.com commented

2020-05-03 23:34:41 +02:00

To add to this, Actually it would be nice to have a toggle for xray. If xray is disabled, it might help us visually when trying to align the plane to object surfaces. But in general use, i think i would keep xray ON since it is a helper tool

Antonio Vazquez commented

2020-05-04 09:57:50 +02:00

@fclem I think that we could disable depth test for Grid Canvas....

index b79d5753686..1620de85a28 100644
    - a/source/blender/draw/engines/overlay/overlay_gpencil.c
+++ b/source/blender/draw/engines/overlay/overlay_gpencil.c
@@ -256,7 +256,7 @@ void OVERLAY_gpencil_cache_init(OVERLAY_Data *vedata)

const int gridlines = (gpd->grid.lines <= 0) ? 1 : gpd->grid.lines;
int line_ct = gridlines * 4 + 2;

 
- DRWState state = DRW_STATE_WRITE_COLOR | DRW_STATE_DEPTH_LESS_EQUAL | DRW_STATE_BLEND_ALPHA;
+    DRWState state = DRW_STATE_WRITE_COLOR | DRW_STATE_BLEND_ALPHA;

DRW_PASS_CREATE(psl->gpencil_canvas_ps, state);

sh = OVERLAY_shader_gpencil_canvas();

What do you think?

@fclem I think that we could disable depth test for Grid Canvas.... ```diff --git a/source/blender/draw/engines/overlay/overlay_gpencil.c b/source/blender/draw/engines/overlay/overlay_gpencil.c index b79d5753686..1620de85a28 100644 - a/source/blender/draw/engines/overlay/overlay_gpencil.c +++ b/source/blender/draw/engines/overlay/overlay_gpencil.c @@ -256,7 +256,7 @@ void OVERLAY_gpencil_cache_init(OVERLAY_Data *vedata) ``` const int gridlines = (gpd->grid.lines <= 0) ? 1 : gpd->grid.lines; int line_ct = gridlines * 4 + 2; ``` - DRWState state = DRW_STATE_WRITE_COLOR | DRW_STATE_DEPTH_LESS_EQUAL | DRW_STATE_BLEND_ALPHA; + DRWState state = DRW_STATE_WRITE_COLOR | DRW_STATE_BLEND_ALPHA; ``` DRW_PASS_CREATE(psl->gpencil_canvas_ps, state); ``` ``` sh = OVERLAY_shader_gpencil_canvas(); ``` ``` What do you think?

Antonio Vazquez commented

2020-05-04 09:58:44 +02:00

Added subscribers: @mendio, @pepe-school-land

Antonio Vazquez commented

2020-05-04 09:58:44 +02:00

@mendio @pepe-school-land Do you think the grid must be always on top?

Antonio Vazquez commented

2020-05-04 09:59:07 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Antonio Vazquez self-assigned this 2020-05-04 09:59:14 +02:00

dupoxy commented

2020-05-04 10:00:30 +02:00

Added subscriber: @dupoxy

dupoxy commented

2020-05-04 10:00:31 +02:00

There is an X-ray toggle but in Solid Viewport shading working right now
but not in Material Preview or Rendered Viewport shading.
{F8511250 size=full}

There is an X-ray toggle but in Solid Viewport shading working right now but not in Material Preview or Rendered Viewport shading. {[F8511250](https://archive.blender.org/developer/F8511250/X-ray.png) size=full}

Antonio Vazquez commented

2020-05-04 12:32:16 +02:00

I don't like to add more switches or reuse X-Ray button. This button is for other things and it's not separated for grid only, so it's not a good solution.

IMHO the best solution is just keep on top all the time as an overlay. Also, we have the opacity of the grid, so if keeping on top is too intrusive, the artist can reduce opacity to get a better experience.

I don't like to add more switches or reuse X-Ray button. This button is for other things and it's not separated for grid only, so it's not a good solution. IMHO the best solution is just keep on top all the time as an overlay. Also, we have the opacity of the grid, so if keeping on top is too intrusive, the artist can reduce opacity to get a better experience.

Antonio Vazquez commented

2020-05-04 17:18:17 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Antonio Vazquez closed this issue

2020-05-04 17:18:17 +02:00

Antonio Vazquez commented

2020-05-04 17:18:17 +02:00

We are being dicussing about the grid canvas and the mayority of the team agree that Grid Canvas must be occluded with 3D geometry if the geometry is in front. This is a change from 2.82, but the new refactored engine allows to do that. The old engine did not supported this occlusion and this was the reason of the "always on top" functionality.

If you need to see the grid, you can enable X-Ray.

If we keep the canvas always on top, it sends a wrong feedback because the final stroke will not be on top, but occluded by the mesh.

I have added this change to the release notes.

We are being dicussing about the grid canvas and the mayority of the team agree that Grid Canvas must be occluded with 3D geometry if the geometry is in front. This is a change from 2.82, but the new refactored engine allows to do that. The old engine did not supported this occlusion and this was the reason of the "always on top" functionality. If you need to see the grid, you can enable X-Ray. ![image.png](https://archive.blender.org/developer/F8512113/image.png) If we keep the canvas always on top, it sends a wrong feedback because the final stroke will not be on top, but occluded by the mesh. I have added this change to the release notes.

Chris Yearn commented

2020-05-13 06:05:04 +02:00

Added subscriber: @yrrnn

Chris Yearn commented

2020-05-13 06:05:04 +02:00

@antoniov I just found this thread as I was also following Dedouze's tutorial and was confused when the canvas was occluded by the cube. I suspect many people would prefer that the canvas is always visible on top even when X-Ray is disabled, would it be possible to add a toggle option to the Viewport Overlays drop-down?

Antonio Vazquez commented

2020-05-13 10:08:08 +02:00

@mendio @pepe-school-land Do you think is good idea add an option to set the Grid on top?

shanenewville@gmail.com commented

2020-05-13 11:39:03 +02:00

A toggle would be good because there may be situations where we do and do not want it on top.

Antonio Vazquez commented

2020-05-13 16:56:41 +02:00

Proposed new option in D7721

Proposed new option in [D7721](https://archive.blender.org/developer/D7721)

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

GPencil: Canvas Plane Is Hidden By Objects / is no longer X-Ray #76366