blender/blender
blender/blender
193
607
Fork 954
Code Issues 6.4k Pull Requests 1.1k Projects 22 Wiki Activity

Cycles viewport unneccessary update calls #76970

New Issue
Open
opened 2020-05-22 13:51:58 +02:00 by Marco · 36 comments
Marco commented 2020-05-22 13:51:58 +02:00
Member
Copy Link

System Information
Operating system: Ubuntu 20.04
Graphics card: Nvidia MX150

Blender Version
Broken: 2.83.17, 8a8c61190b, Beta and 2.90.2, 8f21f867e7, Alpha
Worked: 2.82a official

Short description of error
#76970.blend

  • set scene renderer to Cycles
  • configure two viewports and a shader editor in a single screen
  • set one viewport to cycles preview render
  • set second viewport to workbench texture color
  • add two image texture nodes and load them with different textures
  • by clicking on the texture node both viewports are redrawn.
**System Information** Operating system: Ubuntu 20.04 Graphics card: Nvidia MX150 **Blender Version** Broken: 2.83.17, 8a8c61190b06, Beta and 2.90.2, 8f21f867e715, Alpha Worked: 2.82a official **Short description of error** [#76970.blend](https://archive.blender.org/developer/F8554990/T76970.blend) * set scene renderer to Cycles * configure two viewports and a shader editor in a single screen * set one viewport to cycles preview render * set second viewport to workbench texture color * add two image texture nodes and load them with different textures * by clicking on the texture node both viewports are redrawn.
Marco commented 2020-05-22 13:51:58 +02:00
Author
Member
Copy Link

Added subscriber: @nacioss

Added subscriber: @nacioss
blender-admin commented 2020-05-22 13:51:58 +02:00
Copy Link

#76992 was marked as duplicate of this issue

#76992 was marked as duplicate of this issue
Alaska commented 2020-05-22 13:58:12 +02:00
Member
Copy Link

Added subscriber: @Alaska

Added subscriber: @Alaska
Alaska commented 2020-05-22 13:58:12 +02:00
Member
Copy Link

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Alaska commented 2020-05-22 13:58:12 +02:00
Member
Copy Link

Can confirm. It definitely seems like a bug, but I leave the decision of how to tag this task to the developers as I don't know the reason for why this was changed.

Can confirm. It definitely seems like a bug, but I leave the decision of how to tag this task to the developers as I don't know the reason for why this was changed.
Jeroen Bakker commented 2020-05-22 15:03:49 +02:00
Member
Copy Link

Added subscriber: @Jeroen-Bakker

Added subscriber: @Jeroen-Bakker
Jeroen Bakker commented 2020-05-22 15:03:49 +02:00
Member
Copy Link

Introduced by {27e3361eb5399dc1a700d7f05d5b7b329bc4eafd}

Introduced by {27e3361eb5399dc1a700d7f05d5b7b329bc4eafd}
Bent Hillerkus commented 2020-05-22 15:54:38 +02:00
Copy Link

Added subscriber: @bent

Added subscriber: @bent
Brecht Van Lommel commented 2020-05-22 19:00:29 +02:00
Owner
Copy Link

Added subscribers: @Sergey, @brecht

Added subscribers: @Sergey, @brecht
Brecht Van Lommel commented 2020-05-22 19:00:29 +02:00
Owner
Copy Link

This is an issue for Eevee as well, selecting nodes will also restart the render there.

I guess we need more fine grained depsgraph updates. Ideally the viewport would only redraw when the active texture changes and workbench with texture color is selected.

This is an issue for Eevee as well, selecting nodes will also restart the render there. I guess we need more fine grained depsgraph updates. Ideally the viewport would only redraw when the active texture changes and workbench with texture color is selected.
Nikhil Shringarpurey commented 2020-05-22 19:06:50 +02:00
Member
Copy Link

Added subscriber: @Nikhil.Net

Added subscriber: @Nikhil.Net
Nikhil Shringarpurey commented 2020-05-22 19:06:50 +02:00
Member
Copy Link

I have a potential patch that prevents the depgraph update when clicking/dragging on the background. Basically if the selected node is null, it doesn't fire the update.

Is it worth putting into a diff or would that be considered too simplistic a fix?

I have a potential patch that prevents the depgraph update when clicking/dragging on the background. Basically if the selected node is null, it doesn't fire the update. Is it worth putting into a diff or would that be considered too simplistic a fix?
Nikhil Shringarpurey commented 2020-05-22 20:47:51 +02:00
Member
Copy Link

I did add a diff for this and also caught the use case for when a node is simply clicked on but not changed.

The Diff is https://developer.blender.org/D7824. Should I set Sergey as the reviewer?

I did add a diff for this and also caught the use case for when a node is simply clicked on but not changed. The Diff is https://developer.blender.org/D7824. Should I set Sergey as the reviewer?
Vyacheslav Kobozev commented 2020-05-23 14:49:20 +02:00
Copy Link

Added subscriber: @Vyach

Added subscriber: @Vyach
Vyacheslav Kobozev commented 2020-05-23 15:43:50 +02:00
Copy Link

Additional info: #76992 (Regression: Viewport render recalculations when nothing changed in scene.)
Problem exist since 2.80.

Additional info: #76992 (Regression: Viewport render recalculations when nothing changed in scene.) Problem exist since 2.80.
Eugene Du commented 2020-05-23 22:17:08 +02:00
Copy Link

Added subscriber: @APEC

Added subscriber: @APEC
Alaska commented 2020-05-24 01:07:17 +02:00
Member
Copy Link

Added subscribers: @YegorSmirnov, @MikhailShablin, @TheRedWaxPolice

Added subscribers: @YegorSmirnov, @MikhailShablin, @TheRedWaxPolice
Jeroen Bakker self-assigned this 2020-05-25 08:27:03 +02:00
blender-admin commented 2020-05-25 10:43:44 +02:00
Copy Link

This issue was referenced by 77fdd189e4

This issue was referenced by 77fdd189e4b22d2aa2410109a1a514d21f58d865
Jeroen Bakker commented 2020-05-26 08:30:23 +02:00
Member
Copy Link

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Jeroen Bakker commented 2020-05-26 08:33:43 +02:00
Member
Copy Link

Changed status from 'Resolved' to: 'Confirmed'

Changed status from 'Resolved' to: 'Confirmed'
Jeroen Bakker commented 2020-05-26 08:33:43 +02:00
Member
Copy Link

The current workaround isn't the system we would like to have. The target situation would add a mechanism in the depsgraph where viewports can check if they need to be redrawn.

Currently when you have 2 viewports one Cycles rendered mode and the other in workbench texture mode the updates would still happen.

The current workaround isn't the system we would like to have. The target situation would add a mechanism in the depsgraph where viewports can check if they need to be redrawn. Currently when you have 2 viewports one Cycles rendered mode and the other in workbench texture mode the updates would still happen.
Vyacheslav Kobozev commented 2020-05-26 12:50:29 +02:00
Copy Link

@jabakker imo it is better to have workaround, that work in half of cases, than to have nothing.

But yes, it will be great to have «supervisor», who have list of important changes (and rules), and pokes viewport, when it should rerender view.

@jabakker imo it is better to have workaround, that work in half of cases, than to have nothing. But yes, it will be great to have «supervisor», who have list of important changes (and rules), and pokes viewport, when it should rerender view.
Jeroen Bakker removed their assignment 2020-05-26 14:59:21 +02:00
Vyacheslav Kobozev commented 2020-06-08 22:36:35 +02:00
Copy Link

Thanks guys, I noticed progress in this area today.
Now viewport is not recalculating, when I add routes to disconnected part of tree.
But still called if new disconnected node appears.

Thanks guys, I noticed progress in this area today. Now viewport is not recalculating, when I add routes to disconnected part of tree. But still called if new disconnected node appears.
Ankit Meel commented 2020-06-27 18:56:26 +02:00
Member
Copy Link

Added subscriber: @ankitm

Added subscriber: @ankitm
Ankit Meel commented 2020-06-27 18:56:26 +02:00
Member
Copy Link

(Linking the two reports, so both can be taken care of, when this one is fixed)
#78358 (Crash while modifying shader nodes ): introduced by 77fdd189e4
Edit: it got fixed.

(Linking the two reports, so both can be taken care of, when this one is fixed) #78358 (Crash while modifying shader nodes ): introduced by 77fdd189e4 Edit: it got fixed.
Juanfran Matheu commented 2020-07-27 19:51:49 +02:00
Copy Link

Added subscriber: @jfmatheu

Added subscriber: @jfmatheu
Dalai Felinto commented 2021-04-06 15:21:51 +02:00
Owner
Copy Link

Added subscriber: @dfelinto

Added subscriber: @dfelinto
Dalai Felinto commented 2021-04-06 15:21:51 +02:00
Owner
Copy Link

Without this being in the BF Blender project it doesn't show in most of the tags.

@Jeroen-Bakker FYI instead of removing 2.93 tag you could have just added "BF Blender" tag that would have automatically removed the 2.93 tag AND kept any BF related tag.

Without this being in the BF Blender project it doesn't show in most of the tags. @Jeroen-Bakker FYI instead of removing 2.93 tag you could have just added "BF Blender" tag that would have automatically removed the 2.93 tag AND kept any BF related tag.
Jakub Jaszewski commented 2021-06-21 22:01:53 +02:00
Copy Link

Added subscriber: @silex

Added subscriber: @silex
Jakub Jaszewski commented 2021-06-21 22:01:53 +02:00
Copy Link

Hello.
Over some time of work I compiled a short list of conditions when potentially unwanted calls are made. Will posting it here be helpful?
I tested the cases inside one editor window on the default cube with basic Principled BSDF shader.

Hello. Over some time of work I compiled a short list of conditions when potentially unwanted calls are made. Will posting it here be helpful? I tested the cases inside one editor window on the default cube with basic Principled BSDF shader.
Brecht Van Lommel commented 2021-06-22 14:09:58 +02:00
Owner
Copy Link

Sure, you can post it here.

Sure, you can post it here.
Jakub Jaszewski commented 2021-06-22 18:40:13 +02:00
Copy Link

System Information
platform: 'Linux-5.10.0-7-rt-amd64-x86_64-with-glibc2.31'
Graphics card: AMD Radeon VII (VEGA20, DRM 3.40.0, 5.10.0-7-rt-amd64, LLVM 11.0.1) version: '4.6 (Core Profile) Mesa 20.3.4'

Blender Version
Broken: 3.0.0 Alpha, branch: master, commit date: 2021-06-22 12:06, hash: e3bdb189a7

Steps to reproduce:

  1. Open Default scene
  2. Enable addons: Node Wrangler, Node Arrange
  3. Change Workspace to Shading
  4. Change render engine to Cycles

Viewport updates:

Node connection independent:

  • Picking node from a list (topbar, Shift+A)
  • Pasting copied node(s) (topbar, RMB menu, Ctrl+V)
  • Using Shift+RMB on empty space (without cutting any links)
  • Dragging an image from a File Browser Editor into a Shader Editor
  • Renaming any object in a scene (Outliner, F2 in 3D viewport)

On unused nodes (unconnected to Material Output):

  • Removing node(s) (Ctrl+X)
  • Linking two nodes (F)
  • Linking two nodes (Shift+F)
  • Linking two nodes (Alt+Shift on key release)
  • Linking two nodes (Alt+Shift after choosing connection options)
  • Changing node values (any)
  • Reseting a node (Backspace)

On both used and unused nodes:

  • Duplicating node(s) (topbar, RMB menu, Shift+D)
  • Adding reroute(s) (Shift+RMB)
  • Removing reroute(s) (Ctrl+X)
  • Grabbing input/output socket and releasing the link on an empty space
  • Changing node Name or Label (F2, RMB menu, N panel) - also happens with node frames
  • Adding color to a node (clicking checkbox in N panel) - also happens with node frames
  • Changing node color (color picker in N panel) - also happens with node frames
  • Grouping/ungrouping nodes (topbar, RMB menu, Ctrl+G, Ctrl+Alt+G)
  • Group inserting nodes (topbar)

Node Wrangler & Node Arrange addons - here pretty much every action either used through N panel or shortcut triggers a viewport update.

**System Information** platform: 'Linux-5.10.0-7-rt-amd64-x86_64-with-glibc2.31' Graphics card: AMD Radeon VII (VEGA20, DRM 3.40.0, 5.10.0-7-rt-amd64, LLVM 11.0.1) version: '4.6 (Core Profile) Mesa 20.3.4' **Blender Version** Broken: 3.0.0 Alpha, branch: master, commit date: 2021-06-22 12:06, hash: e3bdb189a777 **Steps to reproduce:** 1. Open Default scene 2. Enable addons: Node Wrangler, Node Arrange 3. Change Workspace to Shading 4. Change render engine to Cycles **Viewport updates:** Node connection independent: - Picking node from a list (topbar, Shift+A) - Pasting copied node(s) (topbar, RMB menu, Ctrl+V) - Using Shift+RMB on empty space (without cutting any links) - Dragging an image from a File Browser Editor into a Shader Editor - Renaming any object in a scene (Outliner, F2 in 3D viewport) On unused nodes (unconnected to Material Output): - Removing node(s) (Ctrl+X) - Linking two nodes (F) - Linking two nodes (Shift+F) - Linking two nodes (Alt+Shift on key release) - Linking two nodes (Alt+Shift after choosing connection options) - Changing node values (any) - Reseting a node (Backspace) On both used and unused nodes: - Duplicating node(s) (topbar, RMB menu, Shift+D) - Adding reroute(s) (Shift+RMB) - Removing reroute(s) (Ctrl+X) - Grabbing input/output socket and releasing the link on an empty space - Changing node Name or Label (F2, RMB menu, N panel) - also happens with node frames - Adding color to a node (clicking checkbox in N panel) - also happens with node frames - Changing node color (color picker in N panel) - also happens with node frames - Grouping/ungrouping nodes (topbar, RMB menu, Ctrl+G, Ctrl+Alt+G) - Group inserting nodes (topbar) Node Wrangler & Node Arrange addons - here pretty much every action either used through N panel or shortcut triggers a viewport update.
Brecht Van Lommel commented 2021-06-22 19:29:08 +02:00
Owner
Copy Link

Ok, we make no effort at all currently to detect which type of node changes need a re-render. If nodes are modified in some way it will refresh. So most listed cases are explained by that.

Object name affect Object Info > Random and potentially OSL scripts, so that also requires a refresh.

Ok, we make no effort at all currently to detect which type of node changes need a re-render. If nodes are modified in some way it will refresh. So most listed cases are explained by that. Object name affect Object Info > Random and potentially OSL scripts, so that also requires a refresh.
Philipp Oeser removed the
Interest
Render & Cycles
 label 2023-02-09 14:00:45 +01:00
Marco commented 2023-10-14 16:07:06 +02:00
Author
Member
Copy Link

This is kind of fixed I guess, but I noticed the viewport being redrawn when you select the Material Output node.

This is kind of fixed I guess, but I noticed the viewport being redrawn when you select the Material Output node.
Brecht Van Lommel commented 2023-10-16 18:48:23 +02:00
Owner
Copy Link

There has indeed been some improvement in this area in the context of improving node updates for geometry nodes. There's still various cases that can be improved though, so will leave this open.

There has indeed been some improvement in this area in the context of improving node updates for geometry nodes. There's still various cases that can be improved though, so will leave this open.
Pratik Borhade commented 2024-05-30 05:50:07 +02:00
Member
Copy Link

Also: #122458

Also: #122458
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Asset datablocks, libraries, browser and shelf
Interest
Audio
Interest
Automated Testing
Interest
BlendFile
Interest
Blender Asset Bundle
Interest
Code Documentation
Code comments, Python/RNA API descriptions
Interest
Collada
Interest
Compatibility
Backward and forward compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
FBX
FBX I/O related topics
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline & IO
Interest
Platforms & Builds
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
USD
Interest
UV Editing
Interest
Undo
Interest
User Interface
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Wayland windowing on Unix
Interest
Workbench
Interest
glTF
glTF format I/O topics
Interest: X11
Xorg/X11 windowing
Legacy
Asset Browser Project
Archived
Legacy
Blender 2.8 Project
Archived
Legacy
Milestone 1: Basic, Local Asset Browser
Archived
Legacy
OpenGL Error
Archived
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Related to security, see policy: https://developer.blender.org/docs/handbook/bug_reports/vulnerability_reports/
Module
Animation & Rigging
Module
Asset System
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline & IO
Module
Platforms & Builds
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
Windows
Platform
macOS
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Archived
Type
Report
Archived
Type
To Do
No Label
Module
Render & Cycles
Severity
Normal
Status
Confirmed
Type
Bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Hoshinova James-McCarthy-4 Sebastian-Herholz casey-bianco-davis gandalf3 Blendify Aaron Carlisle quantimoney Aditya Y Jeppu Alaska Alaska angavrilov Alexander Gavrilov frogstomp Aleš Jelovčan amelief Amélie Fondevilla elubie Andrea Weikert Andy_Goralczyk Andy Goralczyk ankitm Ankit Meel Anthony-Roberts Anthony Roberts antoniov Antonio Vazquez aras_p Aras Pranckevicius Arnd Arnd Marijnissen bartvdbraak Bart van der Braak mont29 Bastien Montagne blender-bot Blender Bot bnagirniak Bogdan Nagirniak BClark Brad Clark brecht Brecht Van Lommel BrianSavery Brian Savery (AMD) ideasman42 Campbell Barton CharlesWardlaw Charles Wardlaw CharlieJolly Charlie Jolly Chris_Blackbourn Chris Blackbourn lateasusual Chris Clyne (Lateasusual) ChrisLend Christoph Lendenfeld HobbesOS Cian Jinks fclem Clément Foucault cmbasnett Colin Basnett Kdaf Colin Marmond dfelinto Dalai Felinto pioverfour Damien Picard DanielBystedt Daniel Bystedt pepe-school-land Daniel Martinez Lara zanqdo Daniel Salazar Mets Demeter Dzadik erik85 Erik Abrahamsson EAW Evan Wilson filedescriptor Falk David fsiddi Francesco Siddi GaiaClary Gaia Clary DagerD Georgiy Markelov mano-wii Germano Cavalcante zazizizou Habib Gahbiche HooglyBoogly Hans Goudey Harley Harley Acheson weasel Henrik D. Hjalti Hjalti Hjálmarsson howardt Howard Trickey nirved-1 Hristo Gueorguiev mod_moder Iliya Katushenock brita Inês Almeida JacquesLucke Jacques Lucke Jason-Fielder Jason Fielder JasonSchleifer Jason schleifer Jebbly Jeffrey Liu Jeroen-Bakker Jeroen Bakker deadpin Jesse Yurkovich neXyon Joerg Mueller eliphaz John Kiril Swenson guitargeek Johnny Matthews Brainzman Jonas Holzman JoniMercado Jonatan Mercado JorgeBernalMartinez Jorge Bernal JosephEagar Joseph Eagar JoshuaLeung Joshua Leung Bone-Studio Juan Gea jpbouza-4 Juan Pablo Bouza JulianEisel Julian Eisel JulienDuroure Julien Duroure JulienKaspar Julien Kaspar kevindietrich Kévin Dietrich lone_noel Leon Schittek LucianoMunoz Luciano Muñoz Sessarego LukasStockner Lukas Stockner LukasTonne Lukas Tönne LunaRood Luna Rood MaiLavelle Mai Lavelle EosFoxx Marion Stalke Baardaap Martijn Versteegh scorpion81 Martin Felke mendio Matias Mendiola Matt-McLin Matt McLin MetinSeven Metin Seven wave Michael B Johnson Michael-Jones Michael Jones (Apple) makowalski Michael Kowalski pragma37 Miguel Pozo nrupsis Nate Rupsis jesterking Nathan Letwory nathanvegdahl Nathan Vegdahl PrototypeNM1 Nicholas Rishel nickberckley Nika Kutsniashvili Sirgienko Nikita Sirgienko OmarEmaraDev Omar Emara pablovazquez Pablo Vazquez PaoloAcampora Paolo Acampora PascalSchon Pascal Schön pmoursnv Patrick Mours muxed-reality Peter Kim lichtwerk Philipp Oeser P2design Pierrick PICAUT PratikPB2123 Pratik Borhade Limarest Ramil Roosileht farsthary Raul Fernandez Hernandez LazyDodo Ray molenkamp iss Richard Antalik rjg Robert Guetzkow salipour Sahar A. Kashi Sayak-Biswas Sayak Biswas Sean-Kim Sean Kim sherholz Sebastian Herholz sebastian_k Sebastian Koenig ZedDB Sebastian Parborg sebbas Sebastián Barschkis Sergey Sergey Sharybin IRIEShinsuke Shinsuke Irie sidd017 Siddhartha Jejurkar SietseB Sietse Brouwer SimonThommes Simon Thommes SonnyCampbell_Unity Sonny Campbell Stefan_Werner Stefan Werner Lockal Sv. Lockal dr.sybren Sybren A. Stüvel ThomasDinges Thomas Dinges Ton Ton Roosendaal BassamKurdali Ursula kurdali Vasyl-Pidhirskyi Vasyl Pidhirskyi WannesMalfait Wannes Malfait wbmoss_dev Wayde Moss weizhen Weizhen Huang leesonw William Leeson xavierh Xavier Hallade jenkm Yevgeny Makarov ChengduLittleA YimingWu gfxcoder jon denning
No Assignees
14 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: blender/blender#76970
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?