Merge remote-tracking branch 'origin/blender-v3.2-release'
This commit is contained in:
commit
3e4f84d10d
|
@ -241,10 +241,11 @@ void FallbackImpl::configGetDefaultLumaCoefs(OCIO_ConstConfigRcPtr * /*config*/,
|
|||
rgb[2] = 0.0722f;
|
||||
}
|
||||
|
||||
void FallbackImpl::configGetXYZtoRGB(OCIO_ConstConfigRcPtr * /*config*/, float xyz_to_rgb[3][3])
|
||||
void FallbackImpl::configGetXYZtoSceneLinear(OCIO_ConstConfigRcPtr * /*config*/,
|
||||
float xyz_to_scene_linear[3][3])
|
||||
{
|
||||
/* Default to ITU-BT.709. */
|
||||
memcpy(xyz_to_rgb, OCIO_XYZ_TO_LINEAR_SRGB, sizeof(OCIO_XYZ_TO_LINEAR_SRGB));
|
||||
memcpy(xyz_to_scene_linear, OCIO_XYZ_TO_REC709, sizeof(OCIO_XYZ_TO_REC709));
|
||||
}
|
||||
|
||||
int FallbackImpl::configGetNumLooks(OCIO_ConstConfigRcPtr * /*config*/)
|
||||
|
|
|
@ -118,9 +118,9 @@ void OCIO_configGetDefaultLumaCoefs(OCIO_ConstConfigRcPtr *config, float *rgb)
|
|||
impl->configGetDefaultLumaCoefs(config, rgb);
|
||||
}
|
||||
|
||||
void OCIO_configGetXYZtoRGB(OCIO_ConstConfigRcPtr *config, float xyz_to_rgb[3][3])
|
||||
void OCIO_configGetXYZtoSceneLinear(OCIO_ConstConfigRcPtr *config, float xyz_to_scene_linear[3][3])
|
||||
{
|
||||
impl->configGetXYZtoRGB(config, xyz_to_rgb);
|
||||
impl->configGetXYZtoSceneLinear(config, xyz_to_scene_linear);
|
||||
}
|
||||
|
||||
int OCIO_configGetNumLooks(OCIO_ConstConfigRcPtr *config)
|
||||
|
|
|
@ -31,10 +31,15 @@ OCIO_DECLARE_HANDLE(OCIO_ConstContextRcPtr);
|
|||
OCIO_DECLARE_HANDLE(OCIO_PackedImageDesc);
|
||||
OCIO_DECLARE_HANDLE(OCIO_ConstLookRcPtr);
|
||||
|
||||
/* Standard XYZ to linear sRGB transform, for fallback. */
|
||||
static const float OCIO_XYZ_TO_LINEAR_SRGB[3][3] = {{3.2404542f, -0.9692660f, 0.0556434f},
|
||||
{-1.5371385f, 1.8760108f, -0.2040259f},
|
||||
{-0.4985314f, 0.0415560f, 1.0572252f}};
|
||||
/* Standard XYZ (D65) to linear Rec.709 transform. */
|
||||
static const float OCIO_XYZ_TO_REC709[3][3] = {{3.2404542f, -0.9692660f, 0.0556434f},
|
||||
{-1.5371385f, 1.8760108f, -0.2040259f},
|
||||
{-0.4985314f, 0.0415560f, 1.0572252f}};
|
||||
/* Standard ACES to XYZ (D65) transform.
|
||||
* Matches OpenColorIO builtin transform: UTILITY - ACES-AP0_to_CIE-XYZ-D65_BFD. */
|
||||
static const float OCIO_ACES_TO_XYZ[3][3] = {{0.938280f, 0.337369f, 0.001174f},
|
||||
{-0.004451f, 0.729522f, -0.003711f},
|
||||
{0.016628f, -0.066890f, 1.091595f}};
|
||||
|
||||
/* This structure is used to pass curve mapping settings from
|
||||
* blender's DNA structure stored in view transform settings
|
||||
|
@ -130,7 +135,8 @@ const char *OCIO_configGetDisplayColorSpaceName(OCIO_ConstConfigRcPtr *config,
|
|||
const char *view);
|
||||
|
||||
void OCIO_configGetDefaultLumaCoefs(OCIO_ConstConfigRcPtr *config, float *rgb);
|
||||
void OCIO_configGetXYZtoRGB(OCIO_ConstConfigRcPtr *config, float xyz_to_rgb[3][3]);
|
||||
void OCIO_configGetXYZtoSceneLinear(OCIO_ConstConfigRcPtr *config,
|
||||
float xyz_to_scene_linear[3][3]);
|
||||
|
||||
int OCIO_configGetNumLooks(OCIO_ConstConfigRcPtr *config);
|
||||
const char *OCIO_configGetLookNameByIndex(OCIO_ConstConfigRcPtr *config, int index);
|
||||
|
|
|
@ -311,13 +311,14 @@ static bool to_scene_linear_matrix(ConstConfigRcPtr &config,
|
|||
return true;
|
||||
}
|
||||
|
||||
void OCIOImpl::configGetXYZtoRGB(OCIO_ConstConfigRcPtr *config_, float xyz_to_rgb[3][3])
|
||||
void OCIOImpl::configGetXYZtoSceneLinear(OCIO_ConstConfigRcPtr *config_,
|
||||
float xyz_to_scene_linear[3][3])
|
||||
{
|
||||
ConstConfigRcPtr config = (*(ConstConfigRcPtr *)config_);
|
||||
|
||||
/* Default to ITU-BT.709 in case no appropriate transform found.
|
||||
* Note XYZ is defined here as having a D65 white point. */
|
||||
memcpy(xyz_to_rgb, OCIO_XYZ_TO_LINEAR_SRGB, sizeof(OCIO_XYZ_TO_LINEAR_SRGB));
|
||||
memcpy(xyz_to_scene_linear, OCIO_XYZ_TO_REC709, sizeof(OCIO_XYZ_TO_REC709));
|
||||
|
||||
/* Get from OpenColorO config if it has the required roles. */
|
||||
if (!config->hasRole(ROLE_SCENE_LINEAR)) {
|
||||
|
@ -326,22 +327,17 @@ void OCIOImpl::configGetXYZtoRGB(OCIO_ConstConfigRcPtr *config_, float xyz_to_rg
|
|||
|
||||
if (config->hasRole("aces_interchange")) {
|
||||
/* Standard OpenColorIO role, defined as ACES AP0 (ACES2065-1). */
|
||||
float aces_to_rgb[3][3];
|
||||
if (to_scene_linear_matrix(config, "aces_interchange", aces_to_rgb)) {
|
||||
/* This is the OpenColorIO builtin transform:
|
||||
* UTILITY - ACES-AP0_to_CIE-XYZ-D65_BFD. */
|
||||
const float ACES_AP0_to_xyz_D65[3][3] = {{0.938280f, 0.337369f, 0.001174f},
|
||||
{-0.004451f, 0.729522f, -0.003711f},
|
||||
{0.016628f, -0.066890f, 1.091595f}};
|
||||
float aces_to_scene_linear[3][3];
|
||||
if (to_scene_linear_matrix(config, "aces_interchange", aces_to_scene_linear)) {
|
||||
float xyz_to_aces[3][3];
|
||||
invert_m3_m3(xyz_to_aces, ACES_AP0_to_xyz_D65);
|
||||
invert_m3_m3(xyz_to_aces, OCIO_ACES_TO_XYZ);
|
||||
|
||||
mul_m3_m3m3(xyz_to_rgb, aces_to_rgb, xyz_to_aces);
|
||||
mul_m3_m3m3(xyz_to_scene_linear, aces_to_scene_linear, xyz_to_aces);
|
||||
}
|
||||
}
|
||||
else if (config->hasRole("XYZ")) {
|
||||
/* Custom role used before the standard existed. */
|
||||
to_scene_linear_matrix(config, "XYZ", xyz_to_rgb);
|
||||
to_scene_linear_matrix(config, "XYZ", xyz_to_scene_linear);
|
||||
}
|
||||
}
|
||||
|
||||
|
|
|
@ -48,7 +48,8 @@ class IOCIOImpl {
|
|||
const char *view) = 0;
|
||||
|
||||
virtual void configGetDefaultLumaCoefs(OCIO_ConstConfigRcPtr *config, float *rgb) = 0;
|
||||
virtual void configGetXYZtoRGB(OCIO_ConstConfigRcPtr *config, float xyz_to_rgb[3][3]) = 0;
|
||||
virtual void configGetXYZtoSceneLinear(OCIO_ConstConfigRcPtr *config,
|
||||
float xyz_to_scene_linear[3][3]) = 0;
|
||||
|
||||
virtual int configGetNumLooks(OCIO_ConstConfigRcPtr *config) = 0;
|
||||
virtual const char *configGetLookNameByIndex(OCIO_ConstConfigRcPtr *config, int index) = 0;
|
||||
|
@ -167,7 +168,7 @@ class FallbackImpl : public IOCIOImpl {
|
|||
const char *view);
|
||||
|
||||
void configGetDefaultLumaCoefs(OCIO_ConstConfigRcPtr *config, float *rgb);
|
||||
void configGetXYZtoRGB(OCIO_ConstConfigRcPtr *config, float xyz_to_rgb[3][3]);
|
||||
void configGetXYZtoSceneLinear(OCIO_ConstConfigRcPtr *config, float xyz_to_scene_linear[3][3]);
|
||||
|
||||
int configGetNumLooks(OCIO_ConstConfigRcPtr *config);
|
||||
const char *configGetLookNameByIndex(OCIO_ConstConfigRcPtr *config, int index);
|
||||
|
@ -257,7 +258,7 @@ class OCIOImpl : public IOCIOImpl {
|
|||
const char *view);
|
||||
|
||||
void configGetDefaultLumaCoefs(OCIO_ConstConfigRcPtr *config, float *rgb);
|
||||
void configGetXYZtoRGB(OCIO_ConstConfigRcPtr *config, float xyz_to_rgb[3][3]);
|
||||
void configGetXYZtoSceneLinear(OCIO_ConstConfigRcPtr *config, float xyz_to_scene_linear[3][3]);
|
||||
|
||||
int configGetNumLooks(OCIO_ConstConfigRcPtr *config);
|
||||
const char *configGetLookNameByIndex(OCIO_ConstConfigRcPtr *config, int index);
|
||||
|
|
|
@ -6277,7 +6277,7 @@ static int ui_do_but_COLOR(bContext *C, uiBut *but, uiHandleButtonData *data, co
|
|||
|
||||
if (but->rnaprop && RNA_property_subtype(but->rnaprop) == PROP_COLOR_GAMMA) {
|
||||
RNA_property_float_get_array(&but->rnapoin, but->rnaprop, target);
|
||||
IMB_colormanagement_srgb_to_scene_linear_v3(target);
|
||||
IMB_colormanagement_srgb_to_scene_linear_v3(target, target);
|
||||
}
|
||||
else if (but->rnaprop && RNA_property_subtype(but->rnaprop) == PROP_COLOR) {
|
||||
RNA_property_float_get_array(&but->rnapoin, but->rnaprop, target);
|
||||
|
@ -6294,7 +6294,7 @@ static int ui_do_but_COLOR(bContext *C, uiBut *but, uiHandleButtonData *data, co
|
|||
}
|
||||
else if (but->rnaprop && RNA_property_subtype(but->rnaprop) == PROP_COLOR) {
|
||||
RNA_property_float_get_array(&but->rnapoin, but->rnaprop, color);
|
||||
IMB_colormanagement_scene_linear_to_srgb_v3(color);
|
||||
IMB_colormanagement_scene_linear_to_srgb_v3(color, color);
|
||||
BKE_brush_color_set(scene, brush, color);
|
||||
updated = true;
|
||||
}
|
||||
|
|
|
@ -1895,14 +1895,14 @@ static int drop_color_invoke(bContext *C, wmOperator *op, const wmEvent *event)
|
|||
|
||||
if (RNA_property_subtype(but->rnaprop) == PROP_COLOR_GAMMA) {
|
||||
if (!gamma) {
|
||||
IMB_colormanagement_scene_linear_to_srgb_v3(color);
|
||||
IMB_colormanagement_scene_linear_to_srgb_v3(color, color);
|
||||
}
|
||||
RNA_property_float_set_array(&but->rnapoin, but->rnaprop, color);
|
||||
RNA_property_update(C, &but->rnapoin, but->rnaprop);
|
||||
}
|
||||
else if (RNA_property_subtype(but->rnaprop) == PROP_COLOR) {
|
||||
if (gamma) {
|
||||
IMB_colormanagement_srgb_to_scene_linear_v3(color);
|
||||
IMB_colormanagement_srgb_to_scene_linear_v3(color, color);
|
||||
}
|
||||
RNA_property_float_set_array(&but->rnapoin, but->rnaprop, color);
|
||||
RNA_property_update(C, &but->rnapoin, but->rnaprop);
|
||||
|
|
|
@ -116,7 +116,7 @@ void ui_scene_linear_to_perceptual_space(uiBut *but, float rgb[3])
|
|||
* assuming it is more perceptually linear than the scene linear
|
||||
* space for intuitive color picking. */
|
||||
if (!ui_but_is_color_gamma(but)) {
|
||||
IMB_colormanagement_scene_linear_to_color_picking_v3(rgb);
|
||||
IMB_colormanagement_scene_linear_to_color_picking_v3(rgb, rgb);
|
||||
ui_color_picker_rgb_round(rgb);
|
||||
}
|
||||
}
|
||||
|
@ -124,7 +124,7 @@ void ui_scene_linear_to_perceptual_space(uiBut *but, float rgb[3])
|
|||
void ui_perceptual_to_scene_linear_space(uiBut *but, float rgb[3])
|
||||
{
|
||||
if (!ui_but_is_color_gamma(but)) {
|
||||
IMB_colormanagement_color_picking_to_scene_linear_v3(rgb);
|
||||
IMB_colormanagement_color_picking_to_scene_linear_v3(rgb, rgb);
|
||||
ui_color_picker_rgb_round(rgb);
|
||||
}
|
||||
}
|
||||
|
@ -208,7 +208,7 @@ static void ui_update_color_picker_buts_rgb(uiBut *from_but,
|
|||
* (coming from other applications, web, etc) */
|
||||
copy_v3_v3(rgb_hex, rgb_scene_linear);
|
||||
if (from_but && !ui_but_is_color_gamma(from_but)) {
|
||||
IMB_colormanagement_scene_linear_to_srgb_v3(rgb_hex);
|
||||
IMB_colormanagement_scene_linear_to_srgb_v3(rgb_hex, rgb_hex);
|
||||
ui_color_picker_rgb_round(rgb_hex);
|
||||
}
|
||||
|
||||
|
@ -291,7 +291,7 @@ static void ui_colorpicker_hex_rna_cb(bContext *UNUSED(C), void *bt1, void *hexc
|
|||
|
||||
/* Hex code is assumed to be in sRGB space (coming from other applications, web, etc) */
|
||||
if (!ui_but_is_color_gamma(but)) {
|
||||
IMB_colormanagement_srgb_to_scene_linear_v3(rgb);
|
||||
IMB_colormanagement_srgb_to_scene_linear_v3(rgb, rgb);
|
||||
ui_color_picker_rgb_round(rgb);
|
||||
}
|
||||
|
||||
|
@ -777,7 +777,7 @@ static void ui_block_colorpicker(uiBlock *block,
|
|||
copy_v3_v3(rgb_hex, rgba_scene_linear);
|
||||
|
||||
if (!ui_but_is_color_gamma(from_but)) {
|
||||
IMB_colormanagement_scene_linear_to_srgb_v3(rgb_hex);
|
||||
IMB_colormanagement_scene_linear_to_srgb_v3(rgb_hex, rgb_hex);
|
||||
ui_color_picker_rgb_round(rgb_hex);
|
||||
}
|
||||
|
||||
|
|
|
@ -359,9 +359,7 @@ void paint_brush_color_get(struct Scene *scene,
|
|||
}
|
||||
/* Gradient / Color-band colors are not considered #PROP_COLOR_GAMMA.
|
||||
* Brush colors are expected to be in sRGB though. */
|
||||
IMB_colormanagement_scene_linear_to_srgb_v3(color_gr);
|
||||
|
||||
copy_v3_v3(color, color_gr);
|
||||
IMB_colormanagement_scene_linear_to_srgb_v3(color, color_gr);
|
||||
}
|
||||
else {
|
||||
copy_v3_v3(color, BKE_brush_color_get(scene, br));
|
||||
|
|
|
@ -331,8 +331,7 @@ static Color vpaint_get_current_col(Scene *scene, VPaint *vp, bool secondary)
|
|||
float color[4];
|
||||
const float *brush_color = secondary ? BKE_brush_secondary_color_get(scene, brush) :
|
||||
BKE_brush_color_get(scene, brush);
|
||||
copy_v3_v3(color, brush_color);
|
||||
IMB_colormanagement_srgb_to_scene_linear_v3(color);
|
||||
IMB_colormanagement_srgb_to_scene_linear_v3(color, brush_color);
|
||||
|
||||
color[3] = 1.0f; /* alpha isn't used, could even be removed to speedup paint a little */
|
||||
|
||||
|
|
|
@ -2001,7 +2001,7 @@ static void sculpt_expand_cache_initial_config_set(bContext *C,
|
|||
BKE_curvemapping_init(expand_cache->brush->curve);
|
||||
copy_v4_fl(expand_cache->fill_color, 1.0f);
|
||||
copy_v3_v3(expand_cache->fill_color, BKE_brush_color_get(ss->scene, expand_cache->brush));
|
||||
IMB_colormanagement_srgb_to_scene_linear_v3(expand_cache->fill_color);
|
||||
IMB_colormanagement_srgb_to_scene_linear_v3(expand_cache->fill_color, expand_cache->fill_color);
|
||||
|
||||
expand_cache->scene = CTX_data_scene(C);
|
||||
expand_cache->mtex = &expand_cache->brush->mtex;
|
||||
|
|
|
@ -298,7 +298,7 @@ static int sculpt_color_filter_modal(bContext *C, wmOperator *op, const wmEvent
|
|||
|
||||
float fill_color[3];
|
||||
RNA_float_get_array(op->ptr, "fill_color", fill_color);
|
||||
IMB_colormanagement_srgb_to_scene_linear_v3(fill_color);
|
||||
IMB_colormanagement_srgb_to_scene_linear_v3(fill_color, fill_color);
|
||||
|
||||
if (filter_strength < 0.0 && !ss->filter_cache->pre_smoothed_color) {
|
||||
sculpt_color_presmooth_init(ss);
|
||||
|
|
|
@ -781,8 +781,7 @@ static int sculpt_sample_color_invoke(bContext *C, wmOperator *op, const wmEvent
|
|||
}
|
||||
|
||||
float color_srgb[3];
|
||||
copy_v3_v3(color_srgb, active_vertex_color);
|
||||
IMB_colormanagement_scene_linear_to_srgb_v3(color_srgb);
|
||||
IMB_colormanagement_scene_linear_to_srgb_v3(color_srgb, active_vertex_color);
|
||||
BKE_brush_color_set(scene, brush, color_srgb);
|
||||
|
||||
WM_event_add_notifier(C, NC_BRUSH | NA_EDITED, brush);
|
||||
|
|
|
@ -124,7 +124,7 @@ static void do_paint_brush_task_cb_ex(void *__restrict userdata,
|
|||
copy_v3_v3(brush_color,
|
||||
ss->cache->invert ? BKE_brush_secondary_color_get(ss->scene, brush) :
|
||||
BKE_brush_color_get(ss->scene, brush));
|
||||
IMB_colormanagement_srgb_to_scene_linear_v3(brush_color);
|
||||
IMB_colormanagement_srgb_to_scene_linear_v3(brush_color, brush_color);
|
||||
|
||||
BKE_pbvh_vertex_iter_begin (ss->pbvh, data->nodes[n], vd, PBVH_ITER_UNIQUE) {
|
||||
SCULPT_orig_vert_data_update(&orig_data, &vd);
|
||||
|
|
|
@ -348,8 +348,14 @@ static int node_add_group_exec(bContext *C, wmOperator *op)
|
|||
|
||||
ED_preview_kill_jobs(CTX_wm_manager(C), CTX_data_main(C));
|
||||
|
||||
const char *node_idname = node_group_idname(C);
|
||||
if (node_idname[0] == '\0') {
|
||||
BKE_report(op->reports, RPT_WARNING, "Could not determine type of group node");
|
||||
return OPERATOR_CANCELLED;
|
||||
}
|
||||
|
||||
bNode *group_node = node_add_node(*C,
|
||||
node_group_idname(C),
|
||||
node_idname,
|
||||
(node_group->type == NTREE_CUSTOM) ? NODE_CUSTOM_GROUP :
|
||||
NODE_GROUP,
|
||||
snode->runtime->cursor[0],
|
||||
|
@ -368,6 +374,21 @@ static int node_add_group_exec(bContext *C, wmOperator *op)
|
|||
return OPERATOR_FINISHED;
|
||||
}
|
||||
|
||||
static bool node_add_group_poll(bContext *C)
|
||||
{
|
||||
if (!ED_operator_node_editable(C)) {
|
||||
return false;
|
||||
}
|
||||
const SpaceNode *snode = CTX_wm_space_node(C);
|
||||
if (snode->edittree->type == NTREE_CUSTOM) {
|
||||
CTX_wm_operator_poll_msg_set(C,
|
||||
"This node editor displays a custom (Python defined) node tree. "
|
||||
"Dropping node groups isn't supported for this.");
|
||||
return false;
|
||||
}
|
||||
return true;
|
||||
}
|
||||
|
||||
static int node_add_group_invoke(bContext *C, wmOperator *op, const wmEvent *event)
|
||||
{
|
||||
ARegion *region = CTX_wm_region(C);
|
||||
|
@ -396,7 +417,7 @@ void NODE_OT_add_group(wmOperatorType *ot)
|
|||
/* callbacks */
|
||||
ot->exec = node_add_group_exec;
|
||||
ot->invoke = node_add_group_invoke;
|
||||
ot->poll = ED_operator_node_editable;
|
||||
ot->poll = node_add_group_poll;
|
||||
|
||||
/* flags */
|
||||
ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO | OPTYPE_INTERNAL;
|
||||
|
|
|
@ -72,9 +72,21 @@ BLI_INLINE float IMB_colormanagement_get_luminance(const float rgb[3]);
|
|||
* Byte equivalent of #IMB_colormanagement_get_luminance().
|
||||
*/
|
||||
BLI_INLINE unsigned char IMB_colormanagement_get_luminance_byte(const unsigned char[3]);
|
||||
BLI_INLINE void IMB_colormanagement_xyz_to_rgb(float rgb[3], const float xyz[3]);
|
||||
BLI_INLINE void IMB_colormanagement_rgb_to_xyz(float xyz[3], const float rgb[3]);
|
||||
const float *IMB_colormanagement_get_xyz_to_rgb(void);
|
||||
|
||||
/**
|
||||
* Conversion between scene linear and other color spaces.
|
||||
*/
|
||||
BLI_INLINE void IMB_colormanagement_xyz_to_scene_linear(float scene_linear[3], const float xyz[3]);
|
||||
BLI_INLINE void IMB_colormanagement_scene_linear_to_xyz(float xyz[3], const float scene_linear[3]);
|
||||
BLI_INLINE void IMB_colormanagement_rec709_to_scene_linear(float scene_linear[3],
|
||||
const float rec709[3]);
|
||||
BLI_INLINE void IMB_colormanagement_scene_linear_to_rec709(float rec709[3],
|
||||
const float scene_linear[3]);
|
||||
BLI_INLINE void IMB_colormanagement_aces_to_scene_linear(float scene_linear[3],
|
||||
const float aces[3]);
|
||||
BLI_INLINE void IMB_colormanagement_scene_linear_to_aces(float aces[3],
|
||||
const float scene_linear[3]);
|
||||
const float *IMB_colormanagement_get_xyz_to_scene_linear(void);
|
||||
|
||||
/** \} */
|
||||
|
||||
|
@ -188,15 +200,19 @@ void IMB_colormanagement_imbuf_to_float_texture(float *out_buffer,
|
|||
* - Color picking values 0..1 map to scene linear values in the 0..1 range,
|
||||
* so that picked albedo values are energy conserving.
|
||||
*/
|
||||
void IMB_colormanagement_scene_linear_to_color_picking_v3(float pixel[3]);
|
||||
void IMB_colormanagement_color_picking_to_scene_linear_v3(float pixel[3]);
|
||||
void IMB_colormanagement_scene_linear_to_color_picking_v3(float color_picking[3],
|
||||
const float scene_linear[3]);
|
||||
void IMB_colormanagement_color_picking_to_scene_linear_v3(float scene_linear[3],
|
||||
const float color_picking[3]);
|
||||
|
||||
/**
|
||||
* Conversion between sRGB, for rare cases like hex color or copy/pasting
|
||||
* between UI theme and scene linear colors.
|
||||
*/
|
||||
void IMB_colormanagement_scene_linear_to_srgb_v3(float pixel[3]);
|
||||
void IMB_colormanagement_srgb_to_scene_linear_v3(float pixel[3]);
|
||||
BLI_INLINE void IMB_colormanagement_scene_linear_to_srgb_v3(float srgb[3],
|
||||
const float scene_linear[3]);
|
||||
BLI_INLINE void IMB_colormanagement_srgb_to_scene_linear_v3(float scene_linear[3],
|
||||
const float srgb[3]);
|
||||
|
||||
/**
|
||||
* Convert pixel from scene linear to display space using default view
|
||||
|
|
|
@ -18,8 +18,12 @@ struct ImBuf;
|
|||
struct OCIO_ConstCPUProcessorRcPtr;
|
||||
|
||||
extern float imbuf_luma_coefficients[3];
|
||||
extern float imbuf_xyz_to_rgb[3][3];
|
||||
extern float imbuf_rgb_to_xyz[3][3];
|
||||
extern float imbuf_scene_linear_to_xyz[3][3];
|
||||
extern float imbuf_xyz_to_scene_linear[3][3];
|
||||
extern float imbuf_scene_linear_to_aces[3][3];
|
||||
extern float imbuf_aces_to_scene_linear[3][3];
|
||||
extern float imbuf_scene_linear_to_rec709[3][3];
|
||||
extern float imbuf_rec709_to_scene_linear[3][3];
|
||||
|
||||
#define MAX_COLORSPACE_NAME 64
|
||||
#define MAX_COLORSPACE_DESCRIPTION 512
|
||||
|
|
|
@ -73,10 +73,12 @@ static int global_tot_looks = 0;
|
|||
|
||||
/* Luma coefficients and XYZ to RGB to be initialized by OCIO. */
|
||||
float imbuf_luma_coefficients[3] = {0.0f};
|
||||
float imbuf_xyz_to_rgb[3][3] = {{0.0f}};
|
||||
float imbuf_rgb_to_xyz[3][3] = {{0.0f}};
|
||||
static float imbuf_xyz_to_linear_srgb[3][3] = {{0.0f}};
|
||||
static float imbuf_linear_srgb_to_xyz[3][3] = {{0.0f}};
|
||||
float imbuf_scene_linear_to_xyz[3][3] = {{0.0f}};
|
||||
float imbuf_xyz_to_scene_linear[3][3] = {{0.0f}};
|
||||
float imbuf_scene_linear_to_rec709[3][3] = {{0.0f}};
|
||||
float imbuf_rec709_to_scene_linear[3][3] = {{0.0f}};
|
||||
float imbuf_scene_linear_to_aces[3][3] = {{0.0f}};
|
||||
float imbuf_aces_to_scene_linear[3][3] = {{0.0f}};
|
||||
|
||||
/* lock used by pre-cached processors getters, so processor wouldn't
|
||||
* be created several times
|
||||
|
@ -573,10 +575,16 @@ static void colormanage_load_config(OCIO_ConstConfigRcPtr *config)
|
|||
|
||||
/* Load luminance coefficients. */
|
||||
OCIO_configGetDefaultLumaCoefs(config, imbuf_luma_coefficients);
|
||||
OCIO_configGetXYZtoRGB(config, imbuf_xyz_to_rgb);
|
||||
invert_m3_m3(imbuf_rgb_to_xyz, imbuf_xyz_to_rgb);
|
||||
copy_m3_m3(imbuf_xyz_to_linear_srgb, OCIO_XYZ_TO_LINEAR_SRGB);
|
||||
invert_m3_m3(imbuf_linear_srgb_to_xyz, imbuf_xyz_to_linear_srgb);
|
||||
|
||||
/* Load standard color spaces. */
|
||||
OCIO_configGetXYZtoSceneLinear(config, imbuf_xyz_to_scene_linear);
|
||||
invert_m3_m3(imbuf_scene_linear_to_xyz, imbuf_xyz_to_scene_linear);
|
||||
|
||||
mul_m3_m3m3(imbuf_scene_linear_to_rec709, OCIO_XYZ_TO_REC709, imbuf_scene_linear_to_xyz);
|
||||
invert_m3_m3(imbuf_rec709_to_scene_linear, imbuf_scene_linear_to_rec709);
|
||||
|
||||
mul_m3_m3m3(imbuf_aces_to_scene_linear, imbuf_xyz_to_scene_linear, OCIO_ACES_TO_XYZ);
|
||||
invert_m3_m3(imbuf_scene_linear_to_aces, imbuf_aces_to_scene_linear);
|
||||
}
|
||||
|
||||
static void colormanage_free_config(void)
|
||||
|
@ -1418,9 +1426,9 @@ bool IMB_colormanagement_space_name_is_srgb(const char *name)
|
|||
return (colorspace && IMB_colormanagement_space_is_srgb(colorspace));
|
||||
}
|
||||
|
||||
const float *IMB_colormanagement_get_xyz_to_rgb()
|
||||
const float *IMB_colormanagement_get_xyz_to_scene_linear()
|
||||
{
|
||||
return &imbuf_xyz_to_rgb[0][0];
|
||||
return &imbuf_xyz_to_scene_linear[0][0];
|
||||
}
|
||||
|
||||
/** \} */
|
||||
|
@ -2313,7 +2321,8 @@ void IMB_colormanagement_imbuf_to_float_texture(float *out_buffer,
|
|||
}
|
||||
}
|
||||
|
||||
void IMB_colormanagement_scene_linear_to_color_picking_v3(float pixel[3])
|
||||
void IMB_colormanagement_scene_linear_to_color_picking_v3(float color_picking[3],
|
||||
const float scene_linear[3])
|
||||
{
|
||||
if (!global_color_picking_state.cpu_processor_to && !global_color_picking_state.failed) {
|
||||
/* Create processor if none exists. */
|
||||
|
@ -2335,12 +2344,15 @@ void IMB_colormanagement_scene_linear_to_color_picking_v3(float pixel[3])
|
|||
BLI_mutex_unlock(&processor_lock);
|
||||
}
|
||||
|
||||
copy_v3_v3(color_picking, scene_linear);
|
||||
|
||||
if (global_color_picking_state.cpu_processor_to) {
|
||||
OCIO_cpuProcessorApplyRGB(global_color_picking_state.cpu_processor_to, pixel);
|
||||
OCIO_cpuProcessorApplyRGB(global_color_picking_state.cpu_processor_to, color_picking);
|
||||
}
|
||||
}
|
||||
|
||||
void IMB_colormanagement_color_picking_to_scene_linear_v3(float pixel[3])
|
||||
void IMB_colormanagement_color_picking_to_scene_linear_v3(float scene_linear[3],
|
||||
const float color_picking[3])
|
||||
{
|
||||
if (!global_color_picking_state.cpu_processor_from && !global_color_picking_state.failed) {
|
||||
/* Create processor if none exists. */
|
||||
|
@ -2362,25 +2374,13 @@ void IMB_colormanagement_color_picking_to_scene_linear_v3(float pixel[3])
|
|||
BLI_mutex_unlock(&processor_lock);
|
||||
}
|
||||
|
||||
copy_v3_v3(scene_linear, color_picking);
|
||||
|
||||
if (global_color_picking_state.cpu_processor_from) {
|
||||
OCIO_cpuProcessorApplyRGB(global_color_picking_state.cpu_processor_from, pixel);
|
||||
OCIO_cpuProcessorApplyRGB(global_color_picking_state.cpu_processor_from, scene_linear);
|
||||
}
|
||||
}
|
||||
|
||||
void IMB_colormanagement_scene_linear_to_srgb_v3(float pixel[3])
|
||||
{
|
||||
mul_m3_v3(imbuf_rgb_to_xyz, pixel);
|
||||
mul_m3_v3(imbuf_xyz_to_linear_srgb, pixel);
|
||||
linearrgb_to_srgb_v3_v3(pixel, pixel);
|
||||
}
|
||||
|
||||
void IMB_colormanagement_srgb_to_scene_linear_v3(float pixel[3])
|
||||
{
|
||||
srgb_to_linearrgb_v3_v3(pixel, pixel);
|
||||
mul_m3_v3(imbuf_linear_srgb_to_xyz, pixel);
|
||||
mul_m3_v3(imbuf_xyz_to_rgb, pixel);
|
||||
}
|
||||
|
||||
void IMB_colormanagement_scene_linear_to_display_v3(float pixel[3], ColorManagedDisplay *display)
|
||||
{
|
||||
OCIO_ConstCPUProcessorRcPtr *processor = display_from_scene_linear_processor(display);
|
||||
|
|
|
@ -27,14 +27,46 @@ unsigned char IMB_colormanagement_get_luminance_byte(const unsigned char rgb[3])
|
|||
return unit_float_to_uchar_clamp(val);
|
||||
}
|
||||
|
||||
void IMB_colormanagement_xyz_to_rgb(float rgb[3], const float xyz[3])
|
||||
void IMB_colormanagement_xyz_to_scene_linear(float scene_linear[3], const float xyz[3])
|
||||
{
|
||||
mul_v3_m3v3(rgb, imbuf_xyz_to_rgb, xyz);
|
||||
mul_v3_m3v3(scene_linear, imbuf_xyz_to_scene_linear, xyz);
|
||||
}
|
||||
|
||||
void IMB_colormanagement_rgb_to_xyz(float xyz[3], const float rgb[3])
|
||||
void IMB_colormanagement_scene_linear_to_xyz(float xyz[3], const float scene_linear[3])
|
||||
{
|
||||
mul_v3_m3v3(xyz, imbuf_rgb_to_xyz, rgb);
|
||||
mul_v3_m3v3(xyz, imbuf_scene_linear_to_xyz, scene_linear);
|
||||
}
|
||||
|
||||
void IMB_colormanagement_rec709_to_scene_linear(float scene_linear[3], const float rec709[3])
|
||||
{
|
||||
mul_v3_m3v3(scene_linear, imbuf_rec709_to_scene_linear, rec709);
|
||||
}
|
||||
|
||||
void IMB_colormanagement_scene_linear_to_rec709(float rec709[3], const float scene_linear[3])
|
||||
{
|
||||
mul_v3_m3v3(rec709, imbuf_scene_linear_to_rec709, scene_linear);
|
||||
}
|
||||
|
||||
void IMB_colormanagement_scene_linear_to_srgb_v3(float srgb[3], const float scene_linear[3])
|
||||
{
|
||||
mul_v3_m3v3(srgb, imbuf_scene_linear_to_rec709, scene_linear);
|
||||
linearrgb_to_srgb_v3_v3(srgb, srgb);
|
||||
}
|
||||
|
||||
void IMB_colormanagement_srgb_to_scene_linear_v3(float scene_linear[3], const float srgb[3])
|
||||
{
|
||||
srgb_to_linearrgb_v3_v3(scene_linear, srgb);
|
||||
mul_m3_v3(imbuf_rec709_to_scene_linear, scene_linear);
|
||||
}
|
||||
|
||||
void IMB_colormanagement_aces_to_scene_linear(float scene_linear[3], const float aces[3])
|
||||
{
|
||||
mul_v3_m3v3(scene_linear, imbuf_aces_to_scene_linear, aces);
|
||||
}
|
||||
|
||||
void IMB_colormanagement_scene_linear_to_aces(float aces[3], const float scene_linear[3])
|
||||
{
|
||||
mul_v3_m3v3(aces, imbuf_scene_linear_to_aces, scene_linear);
|
||||
}
|
||||
|
||||
#endif /* __IMB_COLORMANAGEMENT_INLINE_H__ */
|
||||
|
|
|
@ -2197,7 +2197,7 @@ static void rna_def_mloopcol(BlenderRNA *brna)
|
|||
RNA_def_property_range(prop, 0.0f, 1.0f);
|
||||
RNA_def_property_float_funcs(
|
||||
prop, "rna_MeshLoopColor_color_get", "rna_MeshLoopColor_color_set", NULL);
|
||||
RNA_def_property_ui_text(prop, "Color", "");
|
||||
RNA_def_property_ui_text(prop, "Color", "Color in sRGB color space");
|
||||
RNA_def_property_update(prop, 0, "rna_Mesh_update_data_legacy_deg_tag_all");
|
||||
}
|
||||
|
||||
|
@ -3212,7 +3212,9 @@ static void rna_def_mesh(BlenderRNA *brna)
|
|||
NULL);
|
||||
RNA_def_property_struct_type(prop, "MeshLoopColorLayer");
|
||||
RNA_def_property_override_flag(prop, PROPOVERRIDE_IGNORE);
|
||||
RNA_def_property_ui_text(prop, "Vertex Colors", "All vertex colors");
|
||||
RNA_def_property_ui_text(prop,
|
||||
"Vertex Colors",
|
||||
"Legacy vertex color layers. Deprecated, use color attributes instead");
|
||||
rna_def_loop_colors(brna, prop);
|
||||
|
||||
/* Sculpt Vertex colors */
|
||||
|
@ -3230,7 +3232,9 @@ static void rna_def_mesh(BlenderRNA *brna)
|
|||
NULL);
|
||||
RNA_def_property_struct_type(prop, "MeshVertColorLayer");
|
||||
RNA_def_property_override_flag(prop, PROPOVERRIDE_IGNORE);
|
||||
RNA_def_property_ui_text(prop, "Sculpt Vertex Colors", "All vertex colors");
|
||||
RNA_def_property_ui_text(prop,
|
||||
"Sculpt Vertex Colors",
|
||||
"Sculpt vertex color layers. Deprecated, use color attributes instead");
|
||||
rna_def_vert_colors(brna, prop);
|
||||
|
||||
/* TODO: edge customdata layers (bmesh py api can access already). */
|
||||
|
|
|
@ -329,7 +329,7 @@ void node_shader_gpu_tex_mapping(GPUMaterial *mat,
|
|||
|
||||
void get_XYZ_to_RGB_for_gpu(XYZ_to_RGB *data)
|
||||
{
|
||||
const float *xyz_to_rgb = IMB_colormanagement_get_xyz_to_rgb();
|
||||
const float *xyz_to_rgb = IMB_colormanagement_get_xyz_to_scene_linear();
|
||||
data->r[0] = xyz_to_rgb[0];
|
||||
data->r[1] = xyz_to_rgb[3];
|
||||
data->r[2] = xyz_to_rgb[6];
|
||||
|
|
|
@ -4,6 +4,7 @@ set(INC
|
|||
.
|
||||
../../blenkernel
|
||||
../../blenlib
|
||||
../../imbuf
|
||||
../../bmesh
|
||||
../../depsgraph
|
||||
../../makesdna
|
||||
|
@ -42,6 +43,7 @@ set(SRC
|
|||
|
||||
set(LIB
|
||||
bf_blenlib
|
||||
bf_imbuf
|
||||
bf_python_ext
|
||||
|
||||
${PYTHON_LINKFLAGS}
|
||||
|
|
|
@ -14,6 +14,8 @@
|
|||
#include "../generic/py_capi_utils.h"
|
||||
#include "../generic/python_utildefines.h"
|
||||
|
||||
#include "IMB_colormanagement.h"
|
||||
|
||||
#ifndef MATH_STANDALONE
|
||||
# include "BLI_dynstr.h"
|
||||
#endif
|
||||
|
@ -76,6 +78,120 @@ static PyObject *Color_ToTupleExt(ColorObject *self, int ndigits)
|
|||
return ret;
|
||||
}
|
||||
|
||||
PyDoc_STRVAR(Color_from_scene_linear_to_srgb_doc,
|
||||
".. function:: from_scene_linear_to_srgb()\n"
|
||||
"\n"
|
||||
" Convert from scene linear to sRGB color space.\n"
|
||||
"\n"
|
||||
" :return: A color in sRGB color space.\n"
|
||||
" :rtype: :class:`Color`\n");
|
||||
static PyObject *Color_from_scene_linear_to_srgb(ColorObject *self)
|
||||
{
|
||||
float col[3];
|
||||
IMB_colormanagement_scene_linear_to_srgb_v3(col, self->col);
|
||||
return Color_CreatePyObject(col, Py_TYPE(self));
|
||||
}
|
||||
|
||||
PyDoc_STRVAR(Color_from_srgb_to_scene_linear_doc,
|
||||
".. function:: from_srgb_to_scene_linear()\n"
|
||||
"\n"
|
||||
" Convert from sRGB to scene linear color space.\n"
|
||||
"\n"
|
||||
" :return: A color in scene linear color space.\n"
|
||||
" :rtype: :class:`Color`\n");
|
||||
static PyObject *Color_from_srgb_to_scene_linear(ColorObject *self)
|
||||
{
|
||||
float col[3];
|
||||
IMB_colormanagement_srgb_to_scene_linear_v3(col, self->col);
|
||||
return Color_CreatePyObject(col, Py_TYPE(self));
|
||||
}
|
||||
|
||||
PyDoc_STRVAR(Color_from_scene_linear_to_xyz_d65_doc,
|
||||
".. function:: from_scene_linear_to_xyz_d65()\n"
|
||||
"\n"
|
||||
" Convert from scene linear to CIE XYZ (Illuminant D65) color space.\n"
|
||||
"\n"
|
||||
" :return: A color in XYZ color space.\n"
|
||||
" :rtype: :class:`Color`\n");
|
||||
static PyObject *Color_from_scene_linear_to_xyz_d65(ColorObject *self)
|
||||
{
|
||||
float col[3];
|
||||
IMB_colormanagement_scene_linear_to_xyz(col, self->col);
|
||||
return Color_CreatePyObject(col, Py_TYPE(self));
|
||||
}
|
||||
|
||||
PyDoc_STRVAR(Color_from_xyz_d65_to_scene_linear_doc,
|
||||
".. function:: from_xyz_d65_to_scene_linear()\n"
|
||||
"\n"
|
||||
" Convert from CIE XYZ (Illuminant D65) to scene linear color space.\n"
|
||||
"\n"
|
||||
" :return: A color in scene linear color space.\n"
|
||||
" :rtype: :class:`Color`\n");
|
||||
static PyObject *Color_from_xyz_d65_to_scene_linear(ColorObject *self)
|
||||
{
|
||||
float col[3];
|
||||
IMB_colormanagement_xyz_to_scene_linear(col, self->col);
|
||||
return Color_CreatePyObject(col, Py_TYPE(self));
|
||||
}
|
||||
|
||||
PyDoc_STRVAR(Color_from_scene_linear_to_aces_doc,
|
||||
".. function:: from_scene_linear_to_aces()\n"
|
||||
"\n"
|
||||
" Convert from scene linear to ACES2065-1 linear color space.\n"
|
||||
"\n"
|
||||
" :return: A color in ACES2065-1 linear color space.\n"
|
||||
" :rtype: :class:`Color`\n");
|
||||
static PyObject *Color_from_scene_linear_to_aces(ColorObject *self)
|
||||
{
|
||||
float col[3];
|
||||
IMB_colormanagement_scene_linear_to_aces(col, self->col);
|
||||
return Color_CreatePyObject(col, Py_TYPE(self));
|
||||
}
|
||||
|
||||
PyDoc_STRVAR(Color_from_aces_to_scene_linear_doc,
|
||||
".. function:: from_aces_to_scene_linear()\n"
|
||||
"\n"
|
||||
" Convert from ACES2065-1 linear to scene linear color space.\n"
|
||||
"\n"
|
||||
" :return: A color in scene linear color space.\n"
|
||||
" :rtype: :class:`Color`\n");
|
||||
static PyObject *Color_from_aces_to_scene_linear(ColorObject *self)
|
||||
{
|
||||
float col[3];
|
||||
IMB_colormanagement_aces_to_scene_linear(col, self->col);
|
||||
return Color_CreatePyObject(col, Py_TYPE(self));
|
||||
}
|
||||
|
||||
PyDoc_STRVAR(Color_from_scene_linear_to_rec709_linear_doc,
|
||||
".. function:: from_scene_linear_to_rec709_linear()\n"
|
||||
"\n"
|
||||
" Convert from scene linear to Rec.709 linear color space.\n"
|
||||
"\n"
|
||||
" :return: A color in Rec.709 linear color space.\n"
|
||||
" :rtype: :class:`Color`\n");
|
||||
static PyObject *Color_from_scene_linear_to_rec709_linear(ColorObject *self)
|
||||
{
|
||||
float col[3];
|
||||
IMB_colormanagement_scene_linear_to_rec709(col, self->col);
|
||||
return Color_CreatePyObject(col, Py_TYPE(self));
|
||||
}
|
||||
|
||||
PyDoc_STRVAR(Color_from_rec709_linear_to_scene_linear_doc,
|
||||
".. function:: from_rec709_linear_to_scene_linear()\n"
|
||||
"\n"
|
||||
" Convert from Rec.709 linear color space to scene linear color space.\n"
|
||||
"\n"
|
||||
" :return: A color in scene linear color space.\n"
|
||||
" :rtype: :class:`Color`\n");
|
||||
static PyObject *Color_from_rec709_linear_to_scene_linear(ColorObject *self)
|
||||
{
|
||||
float col[3];
|
||||
IMB_colormanagement_rec709_to_scene_linear(col, self->col);
|
||||
return Color_CreatePyObject(col, Py_TYPE(self));
|
||||
}
|
||||
|
||||
/* ---------------------------- Colorspace conversion -------------- */
|
||||
|
||||
PyDoc_STRVAR(Color_copy_doc,
|
||||
".. function:: copy()\n"
|
||||
"\n"
|
||||
|
@ -869,17 +985,56 @@ static struct PyMethodDef Color_methods[] = {
|
|||
|
||||
/* base-math methods */
|
||||
{"freeze", (PyCFunction)BaseMathObject_freeze, METH_NOARGS, BaseMathObject_freeze_doc},
|
||||
|
||||
/* Colorspace methods. */
|
||||
{"from_scene_linear_to_srgb",
|
||||
(PyCFunction)Color_from_scene_linear_to_srgb,
|
||||
METH_NOARGS,
|
||||
Color_from_scene_linear_to_srgb_doc},
|
||||
{"from_srgb_to_scene_linear",
|
||||
(PyCFunction)Color_from_srgb_to_scene_linear,
|
||||
METH_NOARGS,
|
||||
Color_from_srgb_to_scene_linear_doc},
|
||||
{"from_scene_linear_to_xyz_d65",
|
||||
(PyCFunction)Color_from_scene_linear_to_xyz_d65,
|
||||
METH_NOARGS,
|
||||
Color_from_scene_linear_to_xyz_d65_doc},
|
||||
{"from_xyz_d65_to_scene_linear",
|
||||
(PyCFunction)Color_from_xyz_d65_to_scene_linear,
|
||||
METH_NOARGS,
|
||||
Color_from_xyz_d65_to_scene_linear_doc},
|
||||
{"from_scene_linear_to_aces",
|
||||
(PyCFunction)Color_from_scene_linear_to_aces,
|
||||
METH_NOARGS,
|
||||
Color_from_scene_linear_to_aces_doc},
|
||||
{"from_aces_to_scene_linear",
|
||||
(PyCFunction)Color_from_aces_to_scene_linear,
|
||||
METH_NOARGS,
|
||||
Color_from_aces_to_scene_linear_doc},
|
||||
{"from_scene_linear_to_rec709_linear",
|
||||
(PyCFunction)Color_from_scene_linear_to_rec709_linear,
|
||||
METH_NOARGS,
|
||||
Color_from_scene_linear_to_rec709_linear_doc},
|
||||
{"from_rec709_linear_to_scene_linear",
|
||||
(PyCFunction)Color_from_rec709_linear_to_scene_linear,
|
||||
METH_NOARGS,
|
||||
Color_from_rec709_linear_to_scene_linear_doc},
|
||||
{NULL, NULL, 0, NULL},
|
||||
};
|
||||
|
||||
/* ------------------PY_OBECT DEFINITION-------------------------- */
|
||||
PyDoc_STRVAR(color_doc,
|
||||
".. class:: Color(rgb)\n"
|
||||
"\n"
|
||||
" This object gives access to Colors in Blender.\n"
|
||||
"\n"
|
||||
" :param rgb: (r, g, b) color values\n"
|
||||
" :type rgb: 3d vector\n");
|
||||
PyDoc_STRVAR(
|
||||
color_doc,
|
||||
".. class:: Color(rgb)\n"
|
||||
"\n"
|
||||
" This object gives access to Colors in Blender.\n"
|
||||
"\n"
|
||||
" Most colors returned by Blender APIs are in scene linear color space, as defined by "
|
||||
" the OpenColorIO configuration. The notable exception is user interface theming colors, "
|
||||
" which are in sRGB color space.\n"
|
||||
"\n"
|
||||
" :param rgb: (r, g, b) color values\n"
|
||||
" :type rgb: 3d vector\n");
|
||||
PyTypeObject color_Type = {
|
||||
PyVarObject_HEAD_INIT(NULL, 0) "Color", /* tp_name */
|
||||
sizeof(ColorObject), /* tp_basicsize */
|
||||
|
|
Loading…
Reference in New Issue